Bug 212664 - Revert FEATURES_DEFINES related changes
Summary: Revert FEATURES_DEFINES related changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks: 212418 212420 212541
  Show dependency tree / graph
 
Reported: 2020-06-02 14:41 PDT by Keith Rollin
Modified: 2020-06-04 12:13 PDT (History)
29 users (show)

See Also:

Attachments
Patch (193.79 KB, patch)
2020-06-02 14:45 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-06-02 14:41:18 PDT 
Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to FEATURE_DEFINES and how the values there relate to those found in the Platform*.h files. Those changes break XCBuild (by removing the .xcfilelist related to UnifiedSources and the process for generating them), and so are being reverted.
Comment 1 Radar WebKit Bug Importer 2020-06-02 14:41:31 PDT 
<rdar://problem/63893033>
Comment 2 Keith Rollin 2020-06-02 14:45:15 PDT 
Created attachment 400856 [details]
Patch
Comment 3 Andy Estes 2020-06-02 16:20:06 PDT 
Comment on attachment 400856 [details]
Patch

rs=me. it also seems ok to commit this unreviewed since it fixes the build.
Comment 4 Keith Rollin 2020-06-02 16:24:01 PDT 
I thought it a good idea to pass these changes by others since I was reverting their changes without completely understanding them. But I'll keep your advice in mind for the future.
Comment 5 EWS 2020-06-02 16:52:05 PDT 
Committed r262462: <https://trac.webkit.org/changeset/262462>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400856 [details].