RESOLVED FIXED 212418
[Cocoa] Remove unconditional features from FeatureDefines.xcconfig, making sure they are covered in PlatformEnableCocoa.h
https://bugs.webkit.org/show_bug.cgi?id=212418
Summary [Cocoa] Remove unconditional features from FeatureDefines.xcconfig, making su...
Darin Adler
Reported 2020-05-27 10:41:19 PDT
Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
Attachments
Patch (106.18 KB, patch)
2020-05-27 10:45 PDT, Darin Adler
no flags
Patch (107.31 KB, patch)
2020-05-29 12:08 PDT, Darin Adler
no flags
Patch (103.83 KB, patch)
2020-07-04 10:03 PDT, Darin Adler
no flags
Darin Adler
Comment 1 2020-05-27 10:45:00 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-05-29 12:08:22 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2020-05-29 12:18:29 PDT
After this, with a little more blood, sweat, and tears, we might be able to get rid of all 6 copies of the FeatureDefines.xcconfig file!
Darin Adler
Comment 4 2020-05-29 12:48:04 PDT Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 5 2020-05-29 12:49:15 PDT
Truitt Savell
Comment 6 2020-05-29 14:05:06 PDT Comment hidden (obsolete)
Truitt Savell
Comment 7 2020-05-29 14:06:29 PDT Comment hidden (obsolete)
Darin Adler
Comment 8 2020-05-29 14:25:25 PDT Comment hidden (obsolete)
Andy Estes
Comment 9 2020-06-04 12:12:12 PDT Comment hidden (obsolete)
Darin Adler
Comment 10 2020-07-04 10:03:56 PDT
Darin Adler
Comment 11 2020-07-04 11:47:42 PDT
OK, this one is ready to go now. Looks like the prep work was successful, and all this removal worked!
Sam Weinig
Comment 12 2020-07-04 11:57:35 PDT
Comment on attachment 403528 [details] Patch Very nice!
EWS
Comment 13 2020-07-04 12:21:09 PDT
Committed r263942: <https://trac.webkit.org/changeset/263942> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403528 [details].
Note You need to log in before you can comment on or make changes to this bug.