Bug 212044 - [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one
Summary: [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Christopher Reid
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-18 13:39 PDT by Christopher Reid
Modified: 2020-05-18 19:42 PDT (History)
4 users (show)

See Also:


Attachments
patch (1.51 KB, patch)
2020-05-18 13:44 PDT, Christopher Reid
no flags Details | Formatted Diff | Diff
Patch for landing (4.14 KB, patch)
2020-05-18 19:11 PDT, Christopher Reid
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2020-05-18 13:39:48 PDT
This causes some Service Worker tests which expect clean DataStores to fail because they aren't using the temporary WebsiteDataStore.
Comment 1 Christopher Reid 2020-05-18 13:44:42 PDT
Created attachment 399673 [details]
patch
Comment 2 Don Olmstead 2020-05-18 18:20:31 PDT
Comment on attachment 399673 [details]
patch

There's a related block of code at platformInitializeDataStore which GTK and WPE implement in their respective TestController files. I'd wager that their implementation should just be shared in this file.

Also while you're in there maybe add a !PLATFORM(COCOA) comment at the end of the #if !PLATFORM(COCOA) block this lives in.
Comment 3 Christopher Reid 2020-05-18 18:42:50 PDT
(In reply to Don Olmstead from comment #2)
> Comment on attachment 399673 [details]
> patch
> 
> There's a related block of code at platformInitializeDataStore which GTK and
> WPE implement in their respective TestController files. I'd wager that their
> implementation should just be shared in this file.
> 

Yeah, for reference wincairo recently started to hit crashes without that change similar to r261758.
Comment 4 Christopher Reid 2020-05-18 19:11:00 PDT
Created attachment 399697 [details]
Patch for landing
Comment 5 EWS 2020-05-18 19:41:16 PDT
Committed r261846: <https://trac.webkit.org/changeset/261846>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399697 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-18 19:42:15 PDT
<rdar://problem/63376620>