Bug 210106 - [GTK][WPE] WTR: fix handling of WebsiteDataStore
Summary: [GTK][WPE] WTR: fix handling of WebsiteDataStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 05:33 PDT by Carlos Garcia Campos
Modified: 2020-05-18 17:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2020-04-07 05:36 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-04-07 05:33:19 PDT 
The TestController::defaultWebsiteDataStore() is created and used but never really assigned to the context. Since we are not assigning a WebsiteDataStore to the context, and we don't use the default WebsiteDataStore, when a new page is created, we end up creating the default one (with the default config, instead of the one created by WTR). We should set the TestController::defaultWebsiteDataStore() as the primary data store of the context like the GLib API does.
Comment 1 Carlos Garcia Campos 2020-04-07 05:36:01 PDT 
Created attachment 395672 [details]
Patch
Comment 2 Adrian Perez 2020-04-07 05:53:42 PDT 
Comment on attachment 395672 [details]
Patch

Please make sure that tests pass before landing, otherwise LGTM.
Comment 3 Carlos Garcia Campos 2020-04-07 23:19:30 PDT 
Committed r259705: <https://trac.webkit.org/changeset/259705>
Comment 4 Radar WebKit Bug Importer 2020-04-07 23:20:15 PDT 
<rdar://problem/61433923>