Bug 212031 - webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to webkitpy-ews
Summary: webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to webkitpy-ews
Status: RESOLVED DUPLICATE of bug 222276
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 10:25 PDT by Lauro Moura
Modified: 2022-03-01 02:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2020-05-18 10:30 PDT, Lauro Moura 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-05-18 10:25:04 PDT 
Recently bug212008 was opened to fix some tests from Source/WebKit/Scripts/webkit/messages_unittest.py failing in webkitpy step, but the patch did not trigger the webkitpy EWS bot, with EWS citing "No relevant changes".

This is happening because webkitpy-ews only watches Tools/Scripts/webkitpy (in Tools/BuildSlaveSupport/ews-build/config.json)
Comment 1 Lauro Moura 2020-05-18 10:30:40 PDT 
Created attachment 399655 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-05-18 18:05:28 PDT 
Comment on attachment 399655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399655&action=review

> Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py:69
> +        "Source/WebKit/Scripts/webkit/",

Seeing that test-webkitpy exercises this code, sure. Not sure great that test-webkitpy tests code that is not webkitpy.
Comment 3 Lauro Moura 2021-12-09 11:04:11 PST 

*** This bug has been marked as a duplicate of bug 222276 ***