Bug 211935 - GetByVal and PutByVal runtime operations shouldn't fall off a performance cliff when the property is an integer boxed as a double
Summary: GetByVal and PutByVal runtime operations shouldn't fall off a performance cli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 211877
  Show dependency tree / graph
 
Reported: 2020-05-14 17:12 PDT by Saam Barati
Modified: 2020-05-14 23:56 PDT (History)
14 users (show)

See Also:

Attachments
patch (16.84 KB, patch)
2020-05-14 19:04 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (17.20 KB, patch)
2020-05-14 21:24 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-14 17:12:40 PDT 
...
Comment 1 Saam Barati 2020-05-14 19:04:19 PDT 
Created attachment 399442 [details]
patch
Comment 2 Yusuke Suzuki 2020-05-14 19:10:07 PDT 
Comment on attachment 399442 [details]
patch

r=me
Comment 3 Mark Lam 2020-05-14 19:21:10 PDT 
Comment on attachment 399442 [details]
patch

r=me too.  The style complaint seems legit.  Please fix.
Comment 4 Saam Barati 2020-05-14 20:28:50 PDT 
(In reply to Mark Lam from comment #3)
> Comment on attachment 399442 [details]
> patch
> 
> r=me too.  The style complaint seems legit.  Please fix.

I agree, but the code is unrelated to this patch. 
I can drive by fix it though
Comment 5 Saam Barati 2020-05-14 21:24:49 PDT 
Created attachment 399453 [details]
patch for landing
Comment 6 EWS 2020-05-14 23:55:11 PDT 
Committed r261731: <https://trac.webkit.org/changeset/261731>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399453 [details].
Comment 7 Radar WebKit Bug Importer 2020-05-14 23:56:16 PDT 
<rdar://problem/63259625>