RESOLVED FIXED 211877
Do more speculation that a GetByVal/PutByVal will have an int32 index based on data from ArrayProfile 
https://bugs.webkit.org/show_bug.cgi?id=211877
Summary Do more speculation that a GetByVal/PutByVal will have an int32 index based o...
Saam Barati
Reported 2020-05-13 20:02:20 PDT
And we could do more to stay in Int52. And we could perhaps detect if we always successfully can convert to int32, and speculate as such
Attachments
WIP (26.07 KB, patch)
2020-05-13 20:03 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (25.46 KB, patch)
2020-05-18 13:38 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (4.29 KB, patch)
2020-05-18 15:33 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (4.27 KB, patch)
2020-05-18 15:43 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (5.62 KB, patch)
2020-05-18 15:56 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-05-13 20:03:02 PDT
Created attachment 399327 [details] WIP
Saam Barati
Comment 2 2020-05-18 13:38:01 PDT
Created attachment 399671 [details] WIP ~2.5x faster on microbenchmarks/get-and-put-by-val-double-index-dont-fall-off-a-cliff.js Might hold off a bit until final tuning and landing of this.
Saam Barati
Comment 3 2020-05-18 15:32:21 PDT
Even simpler, and a 3.75x speedup
Saam Barati
Comment 4 2020-05-18 15:33:02 PDT
Created attachment 399678 [details] patch
Saam Barati
Comment 5 2020-05-18 15:43:25 PDT
Created attachment 399679 [details] patch rebased
Saam Barati
Comment 6 2020-05-18 15:56:00 PDT
Created attachment 399680 [details] patch
Yusuke Suzuki
Comment 7 2020-05-18 16:03:07 PDT
Comment on attachment 399680 [details] patch r=me
EWS
Comment 8 2020-05-18 18:17:53 PDT
Committed r261842: <https://trac.webkit.org/changeset/261842> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399680 [details].
Radar WebKit Bug Importer
Comment 9 2020-05-18 18:18:18 PDT
<rdar://problem/63372806>
Note You need to log in before you can comment on or make changes to this bug.