Bug 211877 - Do more speculation that a GetByVal/PutByVal will have an int32 index based on data from ArrayProfile
Summary: Do more speculation that a GetByVal/PutByVal will have an int32 index based o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 211935
Blocks:
  Show dependency tree / graph
 
Reported: 2020-05-13 20:02 PDT by Saam Barati
Modified: 2020-05-18 18:18 PDT (History)
14 users (show)

See Also:

Attachments
WIP (26.07 KB, patch)
2020-05-13 20:03 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (25.46 KB, patch)
2020-05-18 13:38 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.29 KB, patch)
2020-05-18 15:33 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.27 KB, patch)
2020-05-18 15:43 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (5.62 KB, patch)
2020-05-18 15:56 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-13 20:02:20 PDT 
And we could do more to stay in Int52.

And we could perhaps detect if we always successfully can convert to int32, and speculate as such
Comment 1 Saam Barati 2020-05-13 20:03:02 PDT 
Created attachment 399327 [details]
WIP
Comment 2 Saam Barati 2020-05-18 13:38:01 PDT 
Created attachment 399671 [details]
WIP

~2.5x faster on microbenchmarks/get-and-put-by-val-double-index-dont-fall-off-a-cliff.js

Might hold off a bit until final tuning and landing of this.
Comment 3 Saam Barati 2020-05-18 15:32:21 PDT 
Even simpler, and a 3.75x speedup
Comment 4 Saam Barati 2020-05-18 15:33:02 PDT 
Created attachment 399678 [details]
patch
Comment 5 Saam Barati 2020-05-18 15:43:25 PDT 
Created attachment 399679 [details]
patch

rebased
Comment 6 Saam Barati 2020-05-18 15:56:00 PDT 
Created attachment 399680 [details]
patch
Comment 7 Yusuke Suzuki 2020-05-18 16:03:07 PDT 
Comment on attachment 399680 [details]
patch

r=me
Comment 8 EWS 2020-05-18 18:17:53 PDT 
Committed r261842: <https://trac.webkit.org/changeset/261842>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399680 [details].
Comment 9 Radar WebKit Bug Importer 2020-05-18 18:18:18 PDT 
<rdar://problem/63372806>