Bug 211885 – Use enum serialization instead of casting to/from uint32_t

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Use enum serialization instead of casting to/from uint32_t

[Alex Christensen]

Created attachment 399343 [details]
Patch

[Alex Christensen]

Created attachment 399345 [details]
Patch

[Alex Christensen]

Created attachment 399370 [details]
Patch

[Alex Christensen]

Created attachment 399377 [details]
Patch

[Alex Christensen]

Created attachment 399380 [details]
Patch

[Alex Christensen]

Created attachment 399405 [details]
Patch

[Geoffrey Garen]

Comment on attachment 399405 [details]
Patch

r=me

[Alex Christensen]

That test failure looks suspicious.  Will fix before landing.

[Alex Christensen]

Comment on attachment 399405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399405&action=review

> Source/WebCore/page/DOMSelection.cpp:-272
> -    else if (equalLettersIgnoringASCIICase(granularityString, "sentenceboundary"))

This was changed by find/replace by mistake.

> Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:781
> +    return WebGLLoadPolicy::WebGLAllowCreation;

This should be policyResult

[Alex Christensen]

Created attachment 399540 [details]
Patch

[EWS]

Committed r261776: <https://trac.webkit.org/changeset/261776>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399540 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63299590>

[Philippe Normand]

This broke test-webkitpy on most (if not all) platforms:
https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13074/steps/webkitpy-test/logs/stdio

  Traceback (most recent call last):
    File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 335, in test_receiver
      self.check_message(message, _expected_results['messages'][index])
    File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 310, in check_message
      self.assertEquals(len(message.parameters), len(expected_message['parameters']))
  AssertionError: 2 != 1

[Philippe Normand]

message.parameters: [<webkit.model.Parameter object at 0x7f1c2472c550>, <webkit.model.Parameter object at 0x7f1c2472c590>]
expected_message['parameters']: (('IPC::MachPort', 'connectionIdentifier'),)

[Truitt Savell]

(In reply to Philippe Normand from comment #13)
> This broke test-webkitpy on most (if not all) platforms:
> https://build.webkit.org/builders/
> Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13074/steps/webkitpy-
> test/logs/stdio
> 
>   Traceback (most recent call last):
>     File
> "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/
> webkit/messages_unittest.py", line 335, in test_receiver
>       self.check_message(message, _expected_results['messages'][index])
>     File
> "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/
> webkit/messages_unittest.py", line 310, in check_message
>       self.assertEquals(len(message.parameters),
> len(expected_message['parameters']))
>   AssertionError: 2 != 1

Filed https://bugs.webkit.org/show_bug.cgi?id=212025 for this

[Lauro Moura]

(In reply to Truitt Savell from comment #15)
> (In reply to Philippe Normand from comment #13)
> > This broke test-webkitpy on most (if not all) platforms:
> > https://build.webkit.org/builders/
> > Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/13074/steps/webkitpy-
> > test/logs/stdio
> > 
> >   Traceback (most recent call last):
> >     File
> > "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/
> > webkit/messages_unittest.py", line 335, in test_receiver
> >       self.check_message(message, _expected_results['messages'][index])
> >     File
> > "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/
> > webkit/messages_unittest.py", line 310, in check_message
> >       self.assertEquals(len(message.parameters),
> > len(expected_message['parameters']))
> >   AssertionError: 2 != 1
> 
> Filed https://bugs.webkit.org/show_bug.cgi?id=212025 for this

I submitted a fix in bug212008. (Also added it to see-also here but did not comment, sorry).