WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 211814
Make editing-word-with-marker-1.html work on iOS
https://bugs.webkit.org/show_bug.cgi?id=211814
Summary
Make editing-word-with-marker-1.html work on iOS
Daniel Bates
Reported
2020-05-12 16:05:02 PDT
Make editing-word-with-marker-1.html work on iOS. Then I will move it in
bug #211802
.
Attachments
Patch
(17.09 KB, patch)
2020-05-12 16:13 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
To Land
(17.06 KB, patch)
2020-05-17 21:13 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
To Land
(17.08 KB, patch)
2020-05-17 21:14 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2020-05-12 16:13:01 PDT
Created
attachment 399195
[details]
Patch
David Kilzer (:ddkilzer)
Comment 2
2020-05-16 10:27:49 PDT
Comment on
attachment 399195
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=399195&action=review
> LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61 > + textarea.focus();
Why don't we have to do the same thing here as resetText() when calling textarea.focus()? if (window.testRunner) await UIHelper.activateElementAndWaitForInputSession(textarea); else textarea.focus();
Daniel Bates
Comment 3
2020-05-16 10:46:09 PDT
Comment on
attachment 399195
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=399195&action=review
>> LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61 >> + textarea.focus(); > > Why don't we have to do the same thing here as resetText() when calling textarea.focus()? > > if (window.testRunner) > await UIHelper.activateElementAndWaitForInputSession(textarea); > else > textarea.focus();
Focus() not needed. Will remove. It's a no-op in the context of this patch.
Daniel Bates
Comment 4
2020-05-17 21:10:54 PDT
Thanks Simon!
Daniel Bates
Comment 5
2020-05-17 21:13:30 PDT
Created
attachment 399620
[details]
To Land
Daniel Bates
Comment 6
2020-05-17 21:14:23 PDT
Created
attachment 399621
[details]
To Land
Daniel Bates
Comment 7
2020-05-17 21:15:03 PDT
Committed
r261796
: <
https://trac.webkit.org/changeset/261796
>
Radar WebKit Bug Importer
Comment 8
2020-05-17 21:16:14 PDT
<
rdar://problem/63326378
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug