Bug 211814 - Make editing-word-with-marker-1.html work on iOS
Summary: Make editing-word-with-marker-1.html work on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 211802
  Show dependency tree / graph
 
Reported: 2020-05-12 16:05 PDT by Daniel Bates
Modified: 2020-05-17 21:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (17.09 KB, patch)
2020-05-12 16:13 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (17.06 KB, patch)
2020-05-17 21:13 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (17.08 KB, patch)
2020-05-17 21:14 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-05-12 16:05:02 PDT 
Make editing-word-with-marker-1.html work on iOS. Then I will move it in bug #211802.
Comment 1 Daniel Bates 2020-05-12 16:13:01 PDT 
Created attachment 399195 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2020-05-16 10:27:49 PDT 
Comment on attachment 399195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399195&action=review

> LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61
> +    textarea.focus();

Why don't we have to do the same thing here as resetText() when calling textarea.focus()?

    if (window.testRunner)
        await UIHelper.activateElementAndWaitForInputSession(textarea);
    else
        textarea.focus();
Comment 3 Daniel Bates 2020-05-16 10:46:09 PDT 
Comment on attachment 399195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399195&action=review

>> LayoutTests/editing/mac/spelling/editing-word-with-marker-1.html:61
>> +    textarea.focus();
> 
> Why don't we have to do the same thing here as resetText() when calling textarea.focus()?
> 
>     if (window.testRunner)
>         await UIHelper.activateElementAndWaitForInputSession(textarea);
>     else
>         textarea.focus();

Focus() not needed. Will remove. It's a no-op in the context of this patch.
Comment 4 Daniel Bates 2020-05-17 21:10:54 PDT 
Thanks Simon!
Comment 5 Daniel Bates 2020-05-17 21:13:30 PDT 
Created attachment 399620 [details]
To Land
Comment 6 Daniel Bates 2020-05-17 21:14:23 PDT 
Created attachment 399621 [details]
To Land
Comment 7 Daniel Bates 2020-05-17 21:15:03 PDT 
Committed r261796: <https://trac.webkit.org/changeset/261796>
Comment 8 Radar WebKit Bug Importer 2020-05-17 21:16:14 PDT 
<rdar://problem/63326378>