Bug 211802 – Make editing/spelling/editing-word-with-marker-2.html test what it claims and make it work on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

While working on <rdar://problem/61913405> I realized that:

1. Test LayoutTests/editing/spelling/editing-word-with-marker-2.html was originally added to cover updating of markers when whitespace is inserted before an after a misspelling.
2. That test is skipped.
3. The test does not work on iOS.
4. That test was refactored in bug #133544 to no longer test the "insert whitespace after misspelling" case it originally did and which it still claims to do.
5. Some other idiosyncrasies with the refactored test.
6. I can fix the test.

[Daniel Bates]

Created attachment 399173 [details]
Patch

[Daniel Bates]

Comment on attachment 399173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review

> LayoutTests/ChangeLog:13
> +        The fix for iOS was simple: just enable internals.setContinuousSpellCheckingEnabled(). I didn't

^^^ + use UIHelper to activate the element in a way that brings up the keyboard, focus() alone doesn't do the due to iOS policy + blur() the field between tests for maximal code reuse (otherwise I have to keep track/check if the textarea is focused or patch up UIHelper.activateElementAndWaitForInputSession() so it doesn't hang if keyboard is already showing <-- probably a good thing to patch up, but its out of my way)

[Daniel Bates]

Comment on attachment 399173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review

>> LayoutTests/ChangeLog:13
>> +        The fix for iOS was simple: just enable internals.setContinuousSpellCheckingEnabled(). I didn't
> 
> ^^^ + use UIHelper to activate the element in a way that brings up the keyboard, focus() alone doesn't do the due to iOS policy + blur() the field between tests for maximal code reuse (otherwise I have to keep track/check if the textarea is focused or patch up UIHelper.activateElementAndWaitForInputSession() so it doesn't hang if keyboard is already showing <-- probably a good thing to patch up, but its out of my way)

And I'm already going out of my way to fix this test...I don't need to fix this test up for what I need to do.

[Darin Adler]

Comment on attachment 399173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review

> LayoutTests/editing/spelling/editing-word-with-marker-2.html:13
> +    + "is added before or after the misspelled word or the caret is moved."
> +    + "The test succeeds if the word 'meagesga' has a red underline.");

Space after the period before the next sentence?

> LayoutTests/editing/spelling/editing-word-with-marker-2.html:57
> +    debug(`<br>Test: ${testCase.testName}:`);

Does \n work too or do you have to use <br>?

[Daniel Bates]

Created attachment 399196 [details]
Add space between sentences

[Daniel Bates]

Created attachment 399197 [details]
Fix for anticipated WK1 failure

[Daniel Bates]

Created attachment 399198 [details]
Attempt to fix Mac WK2

I'm going to try, but I may choose to skip on WK2.

[Daniel Bates]

Comment on attachment 399173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review

Thanks for the review.

>> LayoutTests/editing/spelling/editing-word-with-marker-2.html:13
>> +    + "The test succeeds if the word 'meagesga' has a red underline.");
> 
> Space after the period before the next sentence?

Fixed.

>> LayoutTests/editing/spelling/editing-word-with-marker-2.html:57
>> +    debug(`<br>Test: ${testCase.testName}:`);
> 
> Does \n work too or do you have to use <br>?

<br> required

[Daniel Bates]

(In reply to Daniel Bates from comment #7)
> Created attachment 399198 [details]
> Attempt to fix Mac WK2
> 
> I'm going to try, but I may choose to skip on WK2.

Experiment failed. Will do what we do now and skip the test on WK2.

[Daniel Bates]

Created attachment 399556 [details]
To Land

[Daniel Bates]

Committed r261783: <https://trac.webkit.org/changeset/261783>

[Radar WebKit Bug Importer]

<rdar://problem/63306358>