Bug 211762 - WPT test importer fails to update references in <link> tags
Summary: WPT test importer fails to update references in <link> tags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 207734
  Show dependency treegraph
 
Reported: 2020-05-11 19:59 PDT by Carlos Alberto Lopez Perez
Modified: 2020-05-12 04:19 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.81 KB, patch)
2020-05-11 20:52 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-05-11 19:59:15 PDT
When importing WPT tests, the WebKit WPT importer rewrites references inside several tags, but fails to update references inside link tags.

This was causing failures when importing the css-flexbox suite in bug 191460

For example the WPT test css/css-flexbox/reference/stretch-input-in-column-ref.html has this:

<link href="../support/flexbox.css" rel="stylesheet">

And the test has to be moved from folder css/css-flexbox/reference/ to css/css-flexbox/ in order to be in the same folder than the test.
So the link href has to be updated accordingly
Comment 1 Carlos Alberto Lopez Perez 2020-05-11 20:52:22 PDT
Created attachment 399094 [details]
Patch
Comment 2 EWS 2020-05-12 04:18:02 PDT
Committed r261552: <https://trac.webkit.org/changeset/261552>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399094 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-12 04:19:16 PDT
<rdar://problem/63131152>