Bug 191460 - Import the Flexbox test suite from the W3C Web Platform Tests
Summary: Import the Flexbox test suite from the W3C Web Platform Tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-09 03:41 PST by Javier Fernandez
Modified: 2020-05-19 07:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.88 MB, patch)
2020-04-22 07:47 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.19 MB, patch)
2020-05-11 21:21 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.91 MB, patch)
2020-05-13 19:56 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.91 MB, patch)
2020-05-14 06:59 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.91 MB, patch)
2020-05-18 14:54 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.91 MB, patch)
2020-05-18 17:36 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.98 MB, patch)
2020-05-19 04:39 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-11-09 03:41:32 PST
We should import the Flexbox test suite, but also, a few tests depend on reference files that belong to such suite.

I'll skip any of those dependent tests while this bug is not fixed.
Comment 1 Carlos Alberto Lopez Perez 2020-04-22 07:47:50 PDT
Created attachment 397188 [details]
Patch

Trying EWS. Ignore
Comment 2 Carlos Alberto Lopez Perez 2020-05-11 21:21:45 PDT
Created attachment 399095 [details]
Patch

test EWS, ignore
Comment 3 Carlos Alberto Lopez Perez 2020-05-13 19:56:36 PDT
Created attachment 399326 [details]
Patch

test EWS, ignore
Comment 4 Carlos Alberto Lopez Perez 2020-05-14 06:59:41 PDT
Created attachment 399357 [details]
Patch

test EWS, ignore
Comment 5 Manuel Rego Casasnovas 2020-05-14 15:45:19 PDT
Comment on attachment 399357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399357&action=review

> LayoutTests/ChangeLog:8
> +        This imports WPT css-flexbox and de-deplicates flexbox tests

Typo: s/de-deplicates/deduplicates/

> LayoutTests/ChangeLog:10
> +        This its the complete list of tests de-duplicated.

Typo: I believe hyphen is not needed, anyway it should be consistent with the one above.
Comment 6 Carlos Alberto Lopez Perez 2020-05-18 14:54:43 PDT
Created attachment 399676 [details]
Patch

Test EWS again. Hopefully green
Comment 7 Carlos Alberto Lopez Perez 2020-05-18 17:36:43 PDT
Created attachment 399688 [details]
Patch

test EWS
Comment 8 Carlos Alberto Lopez Perez 2020-05-18 21:12:08 PDT
Comment on attachment 399688 [details]
Patch

EWS green! asking for review now
Note: i think the style error is not valid.
Comment 9 Sergio Villar Senin 2020-05-19 03:29:13 PDT
Comment on attachment 399688 [details]
Patch

Fix the typo in the ChangeLog (deplicates->duplicates) before landing.
Comment 10 Carlos Alberto Lopez Perez 2020-05-19 04:39:02 PDT
Created attachment 399730 [details]
Patch

patch for landing
Comment 11 EWS 2020-05-19 07:52:09 PDT
Committed r261859: <https://trac.webkit.org/changeset/261859>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399730 [details].
Comment 12 Radar WebKit Bug Importer 2020-05-19 07:53:18 PDT
<rdar://problem/63394960>