Bug 211555 – [GTK] REGRESSION(r260996): Pressing <Tab> in an HTTP authentication dialog makes the dialog lose focus

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adrian Perez]

This can be reproduced easily:

 1. Navigate to https://webmail.igalia.com
 2. The HTTP authentication dialog will show up, with the “Username”
    field focused.
 3. Press <Tab>.

Expected outcome: The “Pasword” field gets the focus, pressing <Tab>
  more time focuses the dialog buttons and then the dialog input fields
  again.

Actual outcom: The HTTP authentication dialog loses the focus, if one
  keeps pressing <Tab> the dialog does not seem to ever get the focus
  back. Interacting with the dialog using the mouse is still possible,
  though.

[Adrian Perez]

Possible related to the changes introduced with bug #211283

[Carlos Garcia Campos]

Yes, I made the focus vfunc GTK4 only by mistake

[Carlos Garcia Campos]

Created attachment 398729 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #3)
> Created attachment 398729 [details]
> Patch

Nice 🤩️

[EWS]

Committed r261284: <https://trac.webkit.org/changeset/261284>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398729 [details].