Bug 211283 - [GTK] Move focus out of the web view when tab is pressed and there isn't a next element to focus
Summary: [GTK] Move focus out of the web view when tab is pressed and there isn't a ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-05-01 04:50 PDT by Carlos Garcia Campos
Modified: 2020-05-01 05:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2020-05-01 04:51 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2020-05-01 04:57 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-05-01 04:50:01 PDT 
We just need to implement API::UIClient::takeFocus()
Comment 1 Carlos Garcia Campos 2020-05-01 04:51:52 PDT 
Created attachment 398173 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-05-01 04:57:35 PDT 
Created attachment 398174 [details]
Patch
Comment 3 EWS Watchlist 2020-05-01 04:58:30 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Adrian Perez 2020-05-01 05:09:46 PDT 
Comment on attachment 398174 [details]
Patch

Lovely nice little patch 😸️
Comment 5 Carlos Garcia Campos 2020-05-01 05:24:01 PDT 
Committed r260996: <https://trac.webkit.org/changeset/260996>