RESOLVED FIXED 211547
Add stack checks to the DFG and FTL bytecode parser. 
https://bugs.webkit.org/show_bug.cgi?id=211547
Summary Add stack checks to the DFG and FTL bytecode parser.
Mark Lam
Reported 2020-05-06 20:35:17 PDT
Inlining can cause some level of recursion of the DFG bytecode parser. We should do a stack check at each inlining check before recursing. If a stack overflow appears to be imminent, then just refuse to inline, and therefore, don't recurse deeper into the parser.
Attachments
proposed patch. (10.84 KB, patch)
2020-05-06 21:07 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (10.83 KB, patch)
2020-05-06 21:38 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-06 20:35:42 PDT
<rdar://problem/62958880>
Mark Lam
Comment 2 2020-05-06 21:07:19 PDT
Created attachment 398701 [details] proposed patch. Let's try this on the EWS first.
Mark Lam
Comment 3 2020-05-06 21:38:17 PDT
Created attachment 398702 [details] proposed patch.
Yusuke Suzuki
Comment 4 2020-05-06 23:32:12 PDT
Comment on attachment 398702 [details] proposed patch. r=me
Mark Lam
Comment 5 2020-05-07 08:17:28 PDT
The ios-wk2 EWS bot failures don't look related to this patch.
Mark Lam
Comment 6 2020-05-07 12:26:35 PDT
Thanks for the review. Landed in r261325: <http://trac.webkit.org/r261325>.
Note You need to log in before you can comment on or make changes to this bug.