Bug 211535 - Give the DFG and FTL WorkList threads more stack space on ASAN builds.
Summary: Give the DFG and FTL WorkList threads more stack space on ASAN builds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-06 15:17 PDT by Mark Lam
Modified: 2020-05-07 12:49 PDT (History)
11 users (show)

See Also:


Attachments
proposed patch. (7.37 KB, patch)
2020-05-06 16:08 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (7.29 KB, patch)
2020-05-06 16:15 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-05-06 15:17:42 PDT
This is because ASAN is a memory hungry beast, and we want the ASAN builds to get to exercise the same amount of code a regular build will (instead of failing out early with a stack overflow error).
Comment 1 Radar WebKit Bug Importer 2020-05-06 15:18:05 PDT
<rdar://problem/62947884>
Comment 2 Mark Lam 2020-05-06 16:08:30 PDT
Created attachment 398678 [details]
proposed patch.
Comment 3 Geoffrey Garen 2020-05-06 16:13:43 PDT
/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WTF/wtf/Threading.cpp:48:46: error: unused parameter 'threadType' [-Werror,-Wunused-parameter]
Comment 4 Mark Lam 2020-05-06 16:15:31 PDT
Created attachment 398680 [details]
proposed patch.
Comment 5 Geoffrey Garen 2020-05-06 16:26:53 PDT
Comment on attachment 398680 [details]
proposed patch.

r=me
Comment 6 Alexey Proskuryakov 2020-05-06 16:33:08 PDT
Will you be rolling back r260692 separately?
Comment 7 Mark Lam 2020-05-06 16:34:25 PDT
(In reply to Alexey Proskuryakov from comment #6)
> Will you be rolling back r260692 separately?

Yes.  Because there's another fix that I need to land first (work in progress).  This bug is only 1 of 2 fixes.
Comment 8 Mark Lam 2020-05-07 12:28:45 PDT
(In reply to Mark Lam from comment #7)
> (In reply to Alexey Proskuryakov from comment #6)
> > Will you be rolling back r260692 separately?
> 
> Yes.  Because there's another fix that I need to land first (work in
> progress).  This bug is only 1 of 2 fixes.

The SUPPRESS_ASAN has been undone in r261325 for https://webkit.org/b/211547.
Comment 9 Mark Lam 2020-05-07 12:29:09 PDT
Comment on attachment 398680 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 10 EWS 2020-05-07 12:49:42 PDT
Committed r261328: <https://trac.webkit.org/changeset/261328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398680 [details].