Bug 211484 – [WebGL2] webgl/2.0.0/conformance[2]/textures/image_bitmap* failures

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

There are several failures in each test underneath webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/ . Initial triage indicates the failures might be caused by WebKit not respecting the premultiplyAlpha option to createImageBitmap, but it's not clear.

To reduce the size of subsequent texture-related rebaselines, these tests are being skipped for the time being. The failures will need to be investigated before the WebGL 2.0 conformance suite can be passed.

[Kenneth Russell]

The image_bitmap_from_blob, image_bitmap_from_image and image_bitmap_from_video tests are all failing for the same reason - WebKit doesn't yet implement the imageOrientation or premultiplyAlpha ImageBitmapOptions:

https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html

This is core functionality and is a blocker for conformance - raising to P1, and assigning to dino@ per recent discussion on Slack.

Affected test directories:

webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/*
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/*
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/*

[Kenneth Russell]

After further discussion with dino@, taking this bug; will attempt a fix.

[Kenneth Russell]

Created attachment 405813 [details]
Patch

[Kenneth Russell]

Created attachment 405814 [details]
Patch

[Kenneth Russell]

The attached patch implements ImageBitmapOptions' ImageOrientation="flipY" and PremultiplyAlpha="premultiply" options, and makes several dozen tests under:
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_canvas/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/

The bulk of the patch is the rebaseline; the code changes are relatively small.

[Kenneth Russell]

Created attachment 405835 [details]
Patch

[EWS]

Committed r265208: <https://trac.webkit.org/changeset/265208>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405835 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66489332>