Bug 211266 – REGRESSION (r258994): Prevents diagnostic logging of network resource loads

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

The change in r258994 was too heavy-handed. Although the SPI is called "_allowSensitiveLogging", it actually prevents any network logging.

We need to hold off on adopting this until it is revised to only address sensitive load logging.

[Brent Fulgham]

<rdar://problem/62461099>

[Brent Fulgham]

Created attachment 398121 [details]
Patch

[Brent Fulgham]

After speaking with Maciej, we will do this another way.

[Brent Fulgham]

We spoke again, and will take this change, but we need to hold off until a blocking bug is fixed.

[Brent Fulgham]

Note: Holding for <rdar://problem/62727212> to be landed.

[Maciej Stachowiak]

Comment on attachment 398121 [details]
Patch

Maybe this is a stretch, but is it possible to make an API test that verifies that logging happens when it's supposed to (and not when it isn't supposed to, i.e. private browsing)?

In any case, r=me

[Brent Fulgham]

(In reply to Brent Fulgham from comment #5)
> Note: Holding for <rdar://problem/62727212> to be landed.

Actually, it's <rdar://problem/62901456> we are holding for.

[Ahmad Saleem]

Checking by BugID, it seems this r+ patch didn't landed. Do we need this now? Thanks!

[Brent Fulgham]

Oh! The relevant changes landed in https://trac.webkit.org/changeset/262332/webkit, after coordinating with the CFNetwork changes needed here.

We can close this.

The fix shipped back in 2020.