Bug 209522 - [Cocoa] Avoid logging sensitive information for all network sessions
Summary: [Cocoa] Avoid logging sensitive information for all network sessions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 211266
  Show dependency tree / graph
 
Reported: 2020-03-24 16:54 PDT by Brent Fulgham
Modified: 2020-05-29 16:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2020-03-24 16:58 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-03-24 16:54:31 PDT 
We avoid logging sensitive information (such as visited URLs) on production builds and for ephemeral sessions.

We should also avoid such logging for engineering and prerelease builds to reduce the possibility of personally identifiable information being retained in logs.
Comment 1 Brent Fulgham 2020-03-24 16:56:17 PDT 
<rdar://problem/54807157>
Comment 2 Brent Fulgham 2020-03-24 16:58:15 PDT 
Created attachment 394442 [details]
Patch
Comment 3 Brent Fulgham 2020-03-24 20:34:39 PDT 
The Windows test case failure is not related to this Cocoa-only change.
Comment 4 EWS 2020-03-25 10:27:07 PDT 
Committed r258994: <https://trac.webkit.org/changeset/258994>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394442 [details].