Bug 211243 - REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
Summary: REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowse...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on: 139308 166801 211587
Blocks: 211586
  Show dependency treegraph
Reported: 2020-04-30 11:46 PDT by David Kilzer (:ddkilzer)
Modified: 2020-05-07 12:13 PDT (History)
4 users (show)

See Also:

Patch v1 (1.59 KB, patch)
2020-04-30 11:48 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-30 11:46:41 PDT
Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m.

Regressed here:

    Bug 139308: Add a private browsing mode to MiniBrowser

    Bug 166801: Add the ability to create empty contentEditable windows in MiniBrowser

Found by clang static analyzer.
Comment 1 David Kilzer (:ddkilzer) 2020-04-30 11:48:54 PDT
Created attachment 398073 [details]
Patch v1
Comment 2 Radar WebKit Bug Importer 2020-04-30 11:49:13 PDT
Comment 3 David Kilzer (:ddkilzer) 2020-04-30 11:59:28 PDT
Comment on attachment 398073 [details]
Patch v1

MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully.
Comment 4 EWS 2020-04-30 12:19:50 PDT
Committed r260959: <https://trac.webkit.org/changeset/260959>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398073 [details].
Comment 5 WebKit Commit Bot 2020-05-07 11:55:19 PDT
Re-opened since this is blocked by bug 211587
Comment 6 Radar WebKit Bug Importer 2020-05-07 12:13:25 PDT