Bug 210989 - [Web Animations] Fix remaining failure in css/css-animations/KeyframeEffect-setKeyframes.tentative
Summary: [Web Animations] Fix remaining failure in css/css-animations/KeyframeEffect-s...
Status: RESOLVED DUPLICATE of bug 234895
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 13:10 PDT by Antoine Quint
Modified: 2022-12-09 04:07 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-24 13:10:49 PDT 
After the patch for bug 210988 lands, there will be one remaining failure in css/css-animations/KeyframeEffect-setKeyframes.tentative.html to address. The remaining failure is caused by AnimationTimeline::updateCSSAnimations() not updating the animation when the underlying @keyframes rule changed. This is due to Animation::animationsMatch not checking on the actual keyframes.
Comment 1 Radar WebKit Bug Importer 2020-04-24 14:43:25 PDT 
<rdar://problem/62340847>
Comment 2 Antoine Quint 2022-12-09 04:07:45 PST 
This got fixed by 234895.

*** This bug has been marked as a duplicate of bug 234895 ***