Bug 210988 - [Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties
Summary: [Web Animations] Ensure calling Web Animations APIs override future CSS Anima...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 13:08 PDT by Antoine Quint
Modified: 2020-04-24 14:43 PDT (History)
7 users (show)

See Also:

Attachments
Patch (39.90 KB, patch)
2020-04-24 13:23 PDT, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-24 13:08:07 PDT 
[Web Animations] Ensure calling Web Animations APIs override future CSS Animations style properties
Comment 1 Antoine Quint 2020-04-24 13:23:28 PDT 
Created attachment 397495 [details]
Patch
Comment 2 Dean Jackson 2020-04-24 13:30:49 PDT 
Comment on attachment 397495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397495&action=review

> Source/WebCore/animation/WebAnimation.cpp:151
> +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect)
> +{
> +    setEffect(WTFMove(newEffect));
> +}

Why does this need a different name for bindings? And the other two below.
Comment 3 Antoine Quint 2020-04-24 13:34:16 PDT 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 397495 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397495&action=review
> 
> > Source/WebCore/animation/WebAnimation.cpp:151
> > +void WebAnimation::setBindingsEffect(RefPtr<AnimationEffect>&& newEffect)
> > +{
> > +    setEffect(WTFMove(newEffect));
> > +}
> 
> Why does this need a different name for bindings? And the other two below.

Because CSSAnimation subclasses this method to apply some overrides. This needs to happen only when the effect is set via the JS API.
Comment 4 Antoine Quint 2020-04-24 14:42:59 PDT 
Committed r260671: <https://trac.webkit.org/changeset/260671>
Comment 5 Radar WebKit Bug Importer 2020-04-24 14:43:19 PDT 
<rdar://problem/62340827>