Bug 210967 - [GTK4] Make it possible to build with GTK4 without errors
Summary: [GTK4] Make it possible to build with GTK4 without errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4 211021 211045
  Show dependency tree / graph
 
Reported: 2020-04-24 06:55 PDT by Carlos Garcia Campos
Modified: 2020-04-27 06:10 PDT (History)
14 users (show)

See Also:

Attachments
Patch (197.80 KB, patch)
2020-04-24 07:06 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (197.82 KB, patch)
2020-04-24 07:13 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (197.76 KB, patch)
2020-04-25 06:45 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-04-24 06:55:16 PDT 
Therew will be warnings for sure, though. The idea is to ifdef everything so that we can have a complete build with GTK4 and then start working on every feature independently checking it actually works.
Comment 1 Carlos Garcia Campos 2020-04-24 07:06:11 PDT 
Created attachment 397453 [details]
Patch
Comment 2 EWS Watchlist 2020-04-24 07:06:57 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2020-04-24 07:13:29 PDT 
Created attachment 397455 [details]
Patch
Comment 4 Carlos Garcia Campos 2020-04-25 06:45:58 PDT 
Created attachment 397562 [details]
Patch

This should fix the api tests.
Comment 5 Adrian Perez 2020-04-27 05:59:17 PDT 
(In reply to Carlos Garcia Campos from comment #3)
> Created attachment 397455 [details]
> Patch

Let's land this. I think we will have more patch review discussion when
implementing back some of the things which will be left unimplemented
for GTK4 with this, but for now stubbing them out to allow the build to
complete is fine, IMO.
Comment 6 Carlos Garcia Campos 2020-04-27 06:10:18 PDT 
Committed r260752: <https://trac.webkit.org/changeset/260752>