Bug 210889 - Jesus Calling app needs more WebSQL
Summary: Jesus Calling app needs more WebSQL
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Blocks: 204907
  Show dependency treegraph
Reported: 2020-04-22 17:19 PDT by Alex Christensen
Modified: 2020-05-14 10:52 PDT (History)
3 users (show)

See Also:

Patch (1.91 KB, patch)
2020-04-22 17:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2020-04-23 13:31 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-04-22 17:19:38 PDT
Jesus Calling app needs more WebSQL
Comment 1 Alex Christensen 2020-04-22 17:20:13 PDT
Created attachment 397293 [details]
Comment 2 Alex Christensen 2020-04-22 17:20:16 PDT
Comment 3 Chris Dumez 2020-04-23 10:15:17 PDT
Comment on attachment 397293 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=397293&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:615
> +    static const bool needsWebSQL = IOSApplication::isJesusCalling() && applicationSDKVersion() <= DYLD_IOS_VERSION_12_2;

Can we make RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() return true in this case instead? This is not the only place where RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() is queried so this fix is incomplete otherwise. There are plenty of places in generated bindings code that check RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled().
Comment 4 Alex Christensen 2020-04-23 13:31:48 PDT
Created attachment 397379 [details]
Comment 5 Chris Dumez 2020-04-23 13:34:52 PDT
Comment on attachment 397379 [details]

Comment 6 EWS 2020-04-23 13:59:56 PDT
Committed r260597: <https://trac.webkit.org/changeset/260597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397379 [details].