Bug 204907 – Disable WebSQL everywhere by default except in tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

We've disabled WebSQL in WK2 for a while. We need to turn off it everywhere.

[Sihui Liu]

Created attachment 384938 [details]
Patch

[Sihui Liu]

Created attachment 384957 [details]
Patch

[youenn fablet]

Comment on attachment 384957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384957&action=review

> Source/WebKitLegacy/mac/ChangeLog:3
> +        Disable WebSQL everywhere by default except in tests

Should we change RuntimeEnableFeatures::m_webSQLEnabled to false?

[Sihui Liu]

Comment on attachment 384957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384957&action=review

>> Source/WebKitLegacy/mac/ChangeLog:3
>> +        Disable WebSQL everywhere by default except in tests
> 
> Should we change RuntimeEnableFeatures::m_webSQLEnabled to false?

Right...forgot to add that after testing! Thanks!

[Sihui Liu]

Created attachment 385020 [details]
Patch

[Sihui Liu]

Created attachment 385185 [details]
Patch

[Sihui Liu]

Created attachment 385186 [details]
Patch

[Geoffrey Garen]

Comment on attachment 385186 [details]
Patch

r=me

Make sure to update the expected test results on Windows before committing.

[Sihui Liu]

Created attachment 386251 [details]
Patch

[Sihui Liu]

Created attachment 386253 [details]
Patch

[Sihui Liu]

Created attachment 386267 [details]
Patch

[Sihui Liu]

Created attachment 386268 [details]
Patch

[Sihui Liu]

Created attachment 386280 [details]
Patch

[Sihui Liu]

Created attachment 386353 [details]
Patch

[Sihui Liu]

Created attachment 386354 [details]
Patch

[Sihui Liu]

Created attachment 386359 [details]
Patch

[Sihui Liu]

Created attachment 386607 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 386607 [details]
Patch

r=me. Let's watch out for Windows builds when we land this as we talked in person.

[WebKit Commit Bot]

Comment on attachment 386607 [details]
Patch

Rejecting attachment 386607 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 386607, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=386607&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204907&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 386607 from bug 204907.
Fetching: https://bugs.webkit.org/attachment.cgi?id=386607
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 17 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/mac/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/win/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/page/RuntimeEnabledFeatures.h
Hunk #1 succeeded at 447 (offset 5 lines).
patching file Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
Hunk #1 FAILED at 205.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h.rej
patching file Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Hunk #1 FAILED at 707.
Hunk #2 succeeded at 3636 with fuzz 1 (offset 22 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKitLegacy/mac/WebView/WebPreferences.mm.rej
patching file Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Hunk #1 succeeded at 636 (offset 3 lines).
patching file Source/WebKitLegacy/mac/WebView/WebView.mm
Hunk #1 succeeded at 3207 with fuzz 2 (offset 5 lines).
patching file Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
Hunk #1 FAILED at 250.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl.rej
patching file Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
Hunk #1 FAILED at 217.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h.rej
patching file Source/WebKitLegacy/win/WebPreferences.cpp
Hunk #1 succeeded at 347 with fuzz 2 (offset 2 lines).
Hunk #2 succeeded at 2420 with fuzz 1 (offset 16 lines).
patching file Source/WebKitLegacy/win/WebPreferences.h
Hunk #1 FAILED at 295.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/win/WebPreferences.h.rej
patching file Source/WebKitLegacy/win/WebView.cpp
Hunk #1 succeeded at 5310 (offset 2 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/TestOptions.h
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/TestOptions.h.rej
patching file Tools/DumpRenderTree/mac/DumpRenderTree.mm
Hunk #1 succeeded at 1008 (offset 2 lines).
patching file Tools/DumpRenderTree/win/DumpRenderTree.cpp
Hunk #1 succeeded at 915 (offset 1 line).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13306554

[Sihui Liu]

Created attachment 388113 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 388113 [details]
Patch

Clearing flags on attachment: 388113

Committed r254856: <https://trac.webkit.org/changeset/254856>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58762402>