Bug 210845 - [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Summary: [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 209694
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-21 21:55 PDT by Darin Adler
Modified: 2020-04-22 21:35 PDT (History)
28 users (show)

See Also:


Attachments
Patch (20.58 KB, patch)
2020-04-21 22:03 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (33.50 KB, patch)
2020-04-22 13:59 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (34.30 KB, patch)
2020-04-22 14:35 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-04-21 21:55:29 PDT
[Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Comment 1 Darin Adler 2020-04-21 22:03:26 PDT
Created attachment 397168 [details]
Patch
Comment 2 Darin Adler 2020-04-21 22:05:02 PDT
Almost ready to go. The only remaining problem is that there is a failure with Apple's internal installhdrs mechanism; will definitely need to fix that before landing.
Comment 3 Darin Adler 2020-04-22 13:59:49 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2020-04-22 14:00:42 PDT
New patch has everything needed now. This includes more than Anders reviewed, but I took the liberty of still leaving his name in as reviewer. Waiting for feedback before I land it.
Comment 5 Alexey Proskuryakov 2020-04-22 14:01:36 PDT
I was 30 seconds too late to complain about not undoing the StringConcatenate.cpp test workaround in this patch...
Comment 6 Darin Adler 2020-04-22 14:03:36 PDT
(In reply to Alexey Proskuryakov from comment #5)
> I was 30 seconds too late to complain about not undoing the
> StringConcatenate.cpp test workaround in this patch...

(For what it's worth, I had fixed that locally less than 30 seconds after posting the first one.)
Comment 7 Darin Adler 2020-04-22 14:35:02 PDT
Created attachment 397261 [details]
Patch
Comment 8 Darin Adler 2020-04-22 15:01:27 PDT
Comment on attachment 397261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397261&action=review

> Tools/ChangeLog:7
> +2020-04-22  Darin Adler  <darin@apple.com>
> +
> +        [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
> +        https://bugs.webkit.org/show_bug.cgi?id=210845
> +
> +        Reviewed by NOBODY (OOPS!).
> +

I’ll fix this before landing.
Comment 9 Darin Adler 2020-04-22 18:06:07 PDT
If I don’t get any more comments in the next couple of hours, I’ll land this.
Comment 10 Darin Adler 2020-04-22 21:34:39 PDT
Committed r260554: <https://trac.webkit.org/changeset/260554>
Comment 11 Radar WebKit Bug Importer 2020-04-22 21:35:17 PDT
<rdar://problem/62230569>