[Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Created attachment 397168 [details]
Almost ready to go. The only remaining problem is that there is a failure with Apple's internal installhdrs mechanism; will definitely need to fix that before landing.
Created attachment 397257 [details]
New patch has everything needed now. This includes more than Anders reviewed, but I took the liberty of still leaving his name in as reviewer. Waiting for feedback before I land it.
I was 30 seconds too late to complain about not undoing the StringConcatenate.cpp test workaround in this patch...
(In reply to Alexey Proskuryakov from comment #5)
> I was 30 seconds too late to complain about not undoing the
> StringConcatenate.cpp test workaround in this patch...
(For what it's worth, I had fixed that locally less than 30 seconds after posting the first one.)
Created attachment 397261 [details]
Comment on attachment 397261 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=397261&action=review
> +2020-04-22 Darin Adler <firstname.lastname@example.org>
> + [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
> + https://bugs.webkit.org/show_bug.cgi?id=210845
> + Reviewed by NOBODY (OOPS!).
I’ll fix this before landing.
If I don’t get any more comments in the next couple of hours, I’ll land this.
Committed r260554: <https://trac.webkit.org/changeset/260554>