Bug 210812 - WTF API test for StringConcatenate failing for internal Apple builds
Summary: WTF API test for StringConcatenate failing for internal Apple builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-21 13:03 PDT by Darin Adler
Modified: 2020-04-22 14:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2020-04-21 13:05 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-04-21 13:03:31 PDT 
WTF API test for StringConcatenate failing for internal Apple builds
Comment 1 Darin Adler 2020-04-21 13:05:50 PDT 
Created attachment 397107 [details]
Patch
Comment 2 Darin Adler 2020-04-21 13:06:17 PDT 
<rdar://problem/62117460>
Comment 3 Brent Fulgham 2020-04-21 13:41:37 PDT 
Comment on attachment 397107 [details]
Patch

Thank you for the fix!
Comment 4 EWS 2020-04-21 13:52:58 PDT 
Committed r260452: <https://trac.webkit.org/changeset/260452>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397107 [details].
Comment 5 Alexey Proskuryakov 2020-04-21 19:16:53 PDT 
Comment on attachment 397107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397107&action=review

Looks like a pretty bad handgun to have such code behave differently between build configurations.

> Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86
> +    // FIXME: Remove this if statement once we have UChar as char16_t in all configurations.

Is there a bug to follow to know when this happens?
Comment 6 Darin Adler 2020-04-21 21:55:53 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> Looks like a pretty bad handgun to have such code behave differently between
> build configurations.

Agreed.

> > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86
> > +    // FIXME: Remove this if statement once we have UChar as char16_t in all configurations.
> 
> Is there a bug to follow to know when this happens?

Bug 210845.
Comment 7 Alexey Proskuryakov 2020-04-22 14:00:40 PDT 
FOOTgun :)