Bug 210770 - Correct the path to libclang_rt.asan_iossim_dynamic.dylib in LC_RPATH
Summary: Correct the path to libclang_rt.asan_iossim_dynamic.dylib in LC_RPATH
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2020-04-20 16:01 PDT by Alexey Proskuryakov
Modified: 2020-04-21 09:59 PDT (History)
3 users (show)

See Also:

proposed fix (1.11 KB, patch)
2020-04-20 16:05 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2020-04-20 16:01:12 PDT
Even though I said "Use a correct LC_RPATH when building with ASan" in bug 196576, that path appears to be incorrect. Not sure how I thought to have successfully tested it a year ago.

The impact is that ASan archives cannot be used when moved between machines with different Xcode versions.

Comment 1 Alexey Proskuryakov 2020-04-20 16:05:45 PDT
Created attachment 397031 [details]
proposed fix
Comment 2 Alex Christensen 2020-04-21 09:39:35 PDT
Comment on attachment 397031 [details]
proposed fix

Comment 3 EWS 2020-04-21 09:58:59 PDT
Committed r260433: <https://trac.webkit.org/changeset/260433>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397031 [details].