Bug 196576 - Use a correct LC_RPATH when building with ASan
Summary: Use a correct LC_RPATH when building with ASan
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-03 16:39 PDT by Alexey Proskuryakov
Modified: 2020-04-20 16:01 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (4.98 KB, patch)
2019-04-03 16:42 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (1.21 KB, patch)
2019-04-04 10:25 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed patch (1.22 KB, patch)
2019-04-04 10:29 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2019-04-03 16:39:36 PDT
Work around rdar://problem/49498092
Comment 1 Alexey Proskuryakov 2019-04-03 16:42:06 PDT
Created attachment 366670 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2019-04-03 16:56:59 PDT
Comment on attachment 366670 [details]
proposed patch

Trying a simpler way...
Comment 3 Alexey Proskuryakov 2019-04-04 10:25:39 PDT
Created attachment 366725 [details]
proposed patch
Comment 4 EWS Watchlist 2019-04-04 10:27:06 PDT
Attachment 366725 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2019-04-04 10:29:34 PDT
Created attachment 366726 [details]
proposed patch
Comment 6 David Kilzer (:ddkilzer) 2019-04-04 15:53:15 PDT
Comment on attachment 366726 [details]
proposed patch

r=me
Comment 7 WebKit Commit Bot 2019-04-04 17:49:46 PDT
Comment on attachment 366726 [details]
proposed patch

Clearing flags on attachment: 366726

Committed r243922: <https://trac.webkit.org/changeset/243922>
Comment 8 WebKit Commit Bot 2019-04-04 17:49:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-04-04 17:50:20 PDT
<rdar://problem/49630459>