RESOLVED FIXED 210734
check-webkit-style should not complain about missing config.h header in WebKitLegacy source files 
https://bugs.webkit.org/show_bug.cgi?id=210734
Summary check-webkit-style should not complain about missing config.h header in WebKi...
David Kilzer (:ddkilzer)
Reported 2020-04-19 22:59:02 PDT
check-webkit-style should not complain about missing config.h header in WebKitLegacy source files. This was a rather easy fix once I found that support for this was added for Source/bmalloc via Bug 205840 in r254140. check-webkit-style: bmalloc doesn't use config.h <https://bugs.webkit.org/show_bug.cgi?id=205840> <https://trac.webkit.org/r254140>
Attachments
Patch v1 (2.59 KB, patch)
2020-04-19 23:05 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-19 23:05:19 PDT
Created attachment 396944 [details] Patch v1
Darin Adler
Comment 2 2020-04-19 23:13:04 PDT
Comment on attachment 396944 [details] Patch v1 Also true for many files in WebKit, although not all. Not sure what the rule is.
David Kilzer (:ddkilzer)
Comment 3 2020-04-19 23:41:31 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 396944 [details] > Patch v1 > > Also true for many files in WebKit, although not all. Not sure what the rule > is. Probably things in "Cocoa" directories? I can run the style checker and find them all (probably need to add a `grep` to that): $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit That's for another patch, though.
EWS
Comment 4 2020-04-20 01:25:38 PDT
Committed r260355: <https://trac.webkit.org/changeset/260355> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-20 01:26:18 PDT
<rdar://problem/62048173>
Note You need to log in before you can comment on or make changes to this bug.