Bug 210734 - check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
Summary: check-webkit-style should not complain about missing config.h header in WebKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 205840
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-19 22:59 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-20 01:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch v1 (2.59 KB, patch)
2020-04-19 23:05 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-19 22:59:02 PDT
check-webkit-style should not complain about missing config.h header in WebKitLegacy source files.

This was a rather easy fix once I found that support for this was added for Source/bmalloc via Bug 205840 in r254140.

check-webkit-style: bmalloc doesn't use config.h
<https://bugs.webkit.org/show_bug.cgi?id=205840>
<https://trac.webkit.org/r254140>
Comment 1 David Kilzer (:ddkilzer) 2020-04-19 23:05:19 PDT
Created attachment 396944 [details]
Patch v1
Comment 2 Darin Adler 2020-04-19 23:13:04 PDT
Comment on attachment 396944 [details]
Patch v1

Also true for many files in WebKit, although not all. Not sure what the rule is.
Comment 3 David Kilzer (:ddkilzer) 2020-04-19 23:41:31 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 396944 [details]
> Patch v1
> 
> Also true for many files in WebKit, although not all. Not sure what the rule
> is.

Probably things in "Cocoa" directories?  I can run the style checker and find them all (probably need to add a `grep` to that):

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit

That's for another patch, though.
Comment 4 EWS 2020-04-20 01:25:38 PDT
Committed r260355: <https://trac.webkit.org/changeset/260355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-20 01:26:18 PDT
<rdar://problem/62048173>