It complains about [build/include_order] for bmalloc files. > $ Tools/Scripts/check-webkit-style Source/bmalloc/bmalloc/Heap.cpp > ERROR: Source/bmalloc/bmalloc/Heap.cpp:26: You should not add a blank line before implementation file's own header. [build/include_order] [4]
Created attachment 386912 [details] PATCH
Created attachment 386916 [details] PATCH
Created attachment 386919 [details] PATCH wrong email address was used in ChangeLog.
Comment on attachment 386919 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=386919&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:312 > + has_config_header: Whether framework uses config.h or not. I don't think you mean framework here, I think this should just be 'Whether the header includes config.h'. bmalloc isn't a framework in the strictest sense, we could probably use 'project' too, I suppose.
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 386919 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386919&action=review > > > Tools/Scripts/webkitpy/style/checkers/cpp.py:312 > > + has_config_header: Whether framework uses config.h or not. > > I don't think you mean framework here, I think this should just be 'Whether > the header includes config.h'. bmalloc isn't a framework in the strictest > sense, we could probably use 'project' too, I suppose. Yes, "project" seems reasonable. Thanks.
Created attachment 386987 [details] PATCH
Comment on attachment 386987 [details] PATCH Clearing flags on attachment: 386987 Committed r254140: <https://trac.webkit.org/changeset/254140>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58380310>