Bug 210460 - Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms
Summary: Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 210479
Blocks: 210438
  Show dependency tree / graph
 
Reported: 2020-04-13 15:29 PDT by Simon Fraser (smfr)
Modified: 2020-04-13 22:32 PDT (History)
15 users (show)

See Also:

Attachments
Patch (19.77 KB, patch)
2020-04-13 15:30 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2020-04-13 20:15 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2020-04-13 21:02 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-13 15:29:00 PDT 
Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms
Comment 1 Simon Fraser (smfr) 2020-04-13 15:30:20 PDT 
Created attachment 396343 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-04-13 17:47:34 PDT 
https://trac.webkit.org/changeset/260052/webkit
Comment 3 Radar WebKit Bug Importer 2020-04-13 17:48:15 PDT 
<rdar://problem/61748309>
Comment 4 Simon Fraser (smfr) 2020-04-13 20:13:53 PDT 
This fix wasn't complete.
Comment 5 Simon Fraser (smfr) 2020-04-13 20:15:25 PDT 
Created attachment 396374 [details]
Patch
Comment 6 Darin Adler 2020-04-13 20:45:44 PDT 
Comment on attachment 396374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396374&action=review

> Source/WTF/wtf/PlatformEnable.h:840
> -#if !defined(ENABLE_CUSTOM_SCROLLBARS)
> +#if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(COCOA)
>  #define ENABLE_CUSTOM_SCROLLBARS 1
>  #endif

This should be fixed in PlatformEnableCocoa.h instead, like this:

#if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(MAC)
#define ENABLE_CUSTOM_SCROLLBARS 0
#endif

PlatformEnableCocoa.h doesn't ever have to set it to 1.
Comment 7 Simon Fraser (smfr) 2020-04-13 21:02:36 PDT 
Created attachment 396378 [details]
Patch
Comment 8 Simon Fraser (smfr) 2020-04-13 22:32:05 PDT 
Rolling out the first patch via bug 210479. I don't have time to address the iOS WK2 failures at present, will postpone this.