Bug 210438 - [Async overflow scroll] Custom scrollbars on gmail don't show
Summary: [Async overflow scroll] Custom scrollbars on gmail don't show
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 210460
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-13 10:19 PDT by Simon Fraser (smfr)
Modified: 2020-04-14 09:04 PDT (History)
9 users (show)

See Also:

Attachments
Reduction (3.86 KB, text/html)
2020-04-13 10:19 PDT, Simon Fraser (smfr) 		no flags Details
Patch (58.55 KB, patch)
2020-04-13 16:21 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (58.53 KB, patch)
2020-04-13 18:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (58.56 KB, patch)
2020-04-13 23:11 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-13 10:19:18 PDT 
Created attachment 396302 [details]
Reduction

With async overflow scrolling enabled, the custom scrollbars on gmail are missing.
Comment 1 Radar WebKit Bug Importer 2020-04-13 10:19:47 PDT 
<rdar://problem/61722541>
Comment 2 Radar WebKit Bug Importer 2020-04-13 10:19:49 PDT 
<rdar://problem/61722545>
Comment 3 Simon Fraser (smfr) 2020-04-13 11:29:31 PDT 
This happens any time we don't make backing store for the scroller; custom scrollbars are currently just painted.
Comment 4 Simon Fraser (smfr) 2020-04-13 16:21:13 PDT 
Created attachment 396355 [details]
Patch
Comment 5 Tim Horton 2020-04-13 16:23:03 PDT 
Comment on attachment 396355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396355&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1791
>  bool RenderLayerBacking::requiresHorizontalScrollbarLayer() const

These functions seem a bit needless now. But maybe they're used externally?
Comment 6 Simon Fraser (smfr) 2020-04-13 18:06:30 PDT 
Created attachment 396366 [details]
Patch
Comment 7 Simon Fraser (smfr) 2020-04-13 21:45:10 PDT 
This is waiting on bug 210460.
Comment 8 Simon Fraser (smfr) 2020-04-13 23:11:17 PDT 
Created attachment 396382 [details]
Patch
Comment 9 EWS 2020-04-14 09:04:26 PDT 
Committed r260074: <https://trac.webkit.org/changeset/260074>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396382 [details].