Bug 210254 - Implement a more efficient tagCFunction() tool.
Summary: Implement a more efficient tagCFunction() tool.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 210252
  Show dependency treegraph
 
Reported: 2020-04-09 01:00 PDT by Mark Lam
Modified: 2020-04-09 02:29 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (63.43 KB, patch)
2020-04-09 01:31 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (63.43 KB, patch)
2020-04-09 01:38 PDT, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-04-09 01:00:39 PDT
The current tagCFunctionPtr() tool does a lot of extra work that is not needed if we are tagging a function and not a potentially arbitrary pointer.  For example,
1. it doesn't need to do a null check.
2. it doesn't need to authenticate the function address.  The RELEASE_ASSERT used to enforce that authentication can also go away.
Comment 1 Mark Lam 2020-04-09 01:31:57 PDT
Created attachment 395921 [details]
proposed patch.
Comment 2 Mark Lam 2020-04-09 01:38:04 PDT
Created attachment 395922 [details]
proposed patch.
Comment 3 Keith Miller 2020-04-09 02:18:41 PDT
Comment on attachment 395922 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-04-09 02:28:16 PDT
Thanks for the review.  Landed in r259786: <http://trac.webkit.org/r259786>.
Comment 5 Radar WebKit Bug Importer 2020-04-09 02:29:17 PDT
<rdar://problem/61506122>