Bug 209873 - Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
Summary: Regression(r257963) didFailProvisionalNavigation delegate no longer gets call...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 208670
  Show dependency tree / graph
 
Reported: 2020-04-01 13:20 PDT by Chris Dumez
Modified: 2020-04-01 14:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.62 KB, patch)
2020-04-01 13:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-01 13:20:19 PDT 
Regression(PSON) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation.
Comment 1 Chris Dumez 2020-04-01 13:20:29 PDT 
<rdar://problem/61132068>
Comment 2 Chris Dumez 2020-04-01 13:33:48 PDT 
Created attachment 395196 [details]
Patch
Comment 3 Alex Christensen 2020-04-01 13:38:52 PDT 
Comment on attachment 395196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395196&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:136
> +    FrameInfoData frameInfo {

FrameInfoData is supposed to only be created in the web process because otherwise it is out of date and the frame could've navigated underneath us.  I don't see another way to do this though.
Comment 4 EWS 2020-04-01 14:01:46 PDT 
Committed r259362: <https://trac.webkit.org/changeset/259362>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395196 [details].