Bug 208670 - Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
Summary: Add WKNavigationDelegatePrivate SPI to inform application of subframe navigat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 209873
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-05 15:47 PST by Alex Christensen
Modified: 2020-04-01 13:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (78.95 KB, patch)
2020-03-05 15:51 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (78.96 KB, patch)
2020-03-05 16:07 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (79.21 KB, patch)
2020-03-05 16:45 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-03-05 15:47:29 PST 
Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
Comment 1 Alex Christensen 2020-03-05 15:51:19 PST 
Created attachment 392639 [details]
Patch
Comment 2 EWS Watchlist 2020-03-05 15:52:02 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alex Christensen 2020-03-05 16:07:36 PST 
Created attachment 392642 [details]
Patch
Comment 4 Alex Christensen 2020-03-05 16:45:13 PST 
Created attachment 392648 [details]
Patch
Comment 5 Brady Eidson 2020-03-05 17:38:39 PST 
Comment on attachment 392648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392648&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:112
> +- (void)_webView:(WKWebView *)webView didStartProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didFailProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame withError:(NSError *)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didCommitLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didFailLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame withError:(NSError *)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +- (void)_webView:(WKWebView *)webView didFinishLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

If this is subframe only, I'd like that to be clear.

"inSubframe:" or "inNonMainFrame:" etc.
Comment 6 Alex Christensen 2020-03-05 18:14:44 PST 
These new SPI callbacks are called for main frame navigations and subframe navigations.  It is correct as it is.
Comment 7 Chris Dumez 2020-04-01 13:35:27 PDT 
This has been committed in http://trac.webkit.org/r257963 but this bug is still open for some reason. This also caused Bug 209873.
Comment 8 Radar WebKit Bug Importer 2020-04-01 13:36:13 PDT 
<rdar://problem/61172788>