RESOLVED FIXED 208670
Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations 
https://bugs.webkit.org/show_bug.cgi?id=208670
Summary Add WKNavigationDelegatePrivate SPI to inform application of subframe navigat...
Alex Christensen
Reported 2020-03-05 15:47:29 PST
Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
Attachments
Patch (78.95 KB, patch)
2020-03-05 15:51 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (78.96 KB, patch)
2020-03-05 16:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (79.21 KB, patch)
2020-03-05 16:45 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-03-05 15:51:19 PST
Created attachment 392639 [details] Patch
EWS Watchlist
Comment 2 2020-03-05 15:52:02 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 3 2020-03-05 16:07:36 PST
Created attachment 392642 [details] Patch
Alex Christensen
Comment 4 2020-03-05 16:45:13 PST
Created attachment 392648 [details] Patch
Brady Eidson
Comment 5 2020-03-05 17:38:39 PST
Comment on attachment 392648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392648&action=review > Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:112 > +- (void)_webView:(WKWebView *)webView didStartProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > +- (void)_webView:(WKWebView *)webView didFailProvisionalLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame withError:(NSError *)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > +- (void)_webView:(WKWebView *)webView didCommitLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > +- (void)_webView:(WKWebView *)webView didFailLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame withError:(NSError *)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > +- (void)_webView:(WKWebView *)webView didFinishLoadWithRequest:(NSURLRequest *)request inFrame:(WKFrameInfo *)frame WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); If this is subframe only, I'd like that to be clear. "inSubframe:" or "inNonMainFrame:" etc.
Alex Christensen
Comment 6 2020-03-05 18:14:44 PST
These new SPI callbacks are called for main frame navigations and subframe navigations. It is correct as it is.
Chris Dumez
Comment 7 2020-04-01 13:35:27 PDT
This has been committed in http://trac.webkit.org/r257963 but this bug is still open for some reason. This also caused Bug 209873.
Radar WebKit Bug Importer
Comment 8 2020-04-01 13:36:13 PDT
<rdar://problem/61172788>
Note You need to log in before you can comment on or make changes to this bug.