webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected.html This test started to fail on macOS after commit r259139 on Release & Debug and wk1 & wk2. History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance2%2Frendering%2Fframebuffer-completeness-unaffected.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected-actual.txt @@ -1,5 +1,15 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance2/rendering/framebuffer-completeness-unaffected.html -[ PASS ] All tests passed +[ 1: PASS ] context exists +[ 2: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 3: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 4: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 5: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. +[ 6: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 7: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. +[ 8: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 9: PASS ] getError was expected value: NO_ERROR : should be no error after setup and clear render buffer +[ 10: PASS ] successfullyParsed is true +[ FAIL ] 2 failures reported
<rdar://problem/61055481>
Taking.
Created attachment 394945 [details] Patch
Comment on attachment 394945 [details] Patch Suppressing as failure to get the bots green. Will investigate further.
Committed r259218: <https://trac.webkit.org/changeset/259218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394945 [details].
(In reply to EWS from comment #5) > Committed r259218: <https://trac.webkit.org/changeset/259218> Reopening since this wasn't a fix, just a test expectations change.
It looks like the fix for Bug 210994 also fixes this conformance failure. Going to leave in the suppression while landing that fix to confirm.
Created attachment 398888 [details] Patch
Committed r261446: <https://trac.webkit.org/changeset/261446> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398888 [details].
This test is still failing on the bots: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected-actual.txt @@ -1,5 +1,15 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance2/rendering/framebuffer-completeness-unaffected.html -[ PASS ] All tests passed +[ 1: PASS ] context exists +[ 2: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 3: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 4: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 5: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. +[ 6: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 7: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. +[ 8: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +[ 9: PASS ] getError was expected value: NO_ERROR : should be no error after setup and clear render buffer +[ 10: PASS ] successfullyParsed is true +[ FAIL ] 2 failures reported
Reverted r261446 for reason: The test is still failing. Committed r261492: <https://trac.webkit.org/changeset/261492>
Created attachment 399050 [details] Patch
Thanks for pointing that out. Re-suppressing in the just-uploaded patch. Example failures: "Catalina E wk2 Release on Macmini8,1": https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Tests/builds/5427 "Catalina E wk2 Debug on iMac16,2": https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-WebGL-Tests/builds/1199 Failure mode is the same on both: This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance2/rendering/framebuffer-completeness-unaffected.html 4[ 1: PASS ] context exists 5[ 2: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE 6[ 3: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE 7[ 4: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE 8[ 5: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. 9[ 6: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE 10[ 7: FAIL ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. 11[ 8: PASS ] gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE 12[ 9: PASS ] getError was expected value: NO_ERROR : should be no error after setup and clear render buffer 13[ 10: PASS ] successfullyParsed is true 14[ FAIL ] 2 failures reported The failures are probably related to the GPU and OpenGL driver on these bots. Will investigate again later.
Thanks ryanhaddad@ for reverting.