RESOLVED FIXED Bug 209689
Update ANGLE to 2020-03-27 
https://bugs.webkit.org/show_bug.cgi?id=209689
Summary Update ANGLE to 2020-03-27
Kenneth Russell
Reported 2020-03-27 16:45:47 PDT
Update ANGLE in WebKit to the version of 2020-03-27 to roll in the fix for anglebug.com/4504 (currently cherry-picked in WebKit) and others.
Attachments
Patch (8.36 MB, patch)
2020-04-03 17:59 PDT, Kenneth Russell 		darin: review+
DetailsFormatted DiffDiff
Patch (8.08 MB, patch)
2020-04-06 12:16 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-04-01 23:30:50 PDT
Status update: fixed a problem in the ANGLE roll script regarding how the commit ID is generated. Tighter validation in updated ANGLE uncovered a few bugs in VideoTextureCopierCV.cpp, but there seems to be one bug in ANGLE around rendering feedback loop detection for which I'm trying to create a standalone test case and report upstream in the ANGLE project.
Kenneth Russell
Comment 2 2020-04-03 17:59:56 PDT
Created attachment 395422 [details] Patch
Kenneth Russell
Comment 3 2020-04-03 18:01:53 PDT
The attached patch is purely an ANGLE roll - all corollary changes were made in Bug 209943. changes.diff has been automatically updated, and no manual changes were made during this roll aside from updating the Xcode project.
EWS Watchlist
Comment 4 2020-04-03 18:04:22 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Darin Adler
Comment 5 2020-04-04 16:19:16 PDT
Comment on attachment 395422 [details] Patch No real value in the file/function list for a change done by a script like this one. I suggest omitting it as I have done with many other patches like this.
Kenneth Russell
Comment 6 2020-04-06 12:16:18 PDT
Created attachment 395599 [details] Patch
EWS
Comment 7 2020-04-06 12:19:28 PDT
kbr@google.com does not have committer permissions according to https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 395599 [details] from commit queue.
EWS
Comment 8 2020-04-06 13:12:49 PDT
Committed r259589: <https://trac.webkit.org/changeset/259589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395599 [details].
Radar WebKit Bug Importer
Comment 9 2020-04-06 13:13:19 PDT
<rdar://problem/61355846>
Dean Jackson
Comment 10 2020-05-07 13:30:54 PDT
I had to revert this in r261262 because it caused https://bugs.webkit.org/show_bug.cgi?id=210992
Dean Jackson
Comment 11 2020-05-15 15:33:00 PDT
Relanded in r261750
Note You need to log in before you can comment on or make changes to this bug.