Bug 209598 - [ews] status-bubble for tester queues should point to tester queue while waiting in queue
Summary: [ews] status-bubble for tester queues should point to tester queue while wait...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-26 08:14 PDT by Aakash Jain
Modified: 2020-03-26 12:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2020-03-26 08:20 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Screenshot of the change (427.08 KB, image/png)
2020-03-26 12:20 PDT, Aakash Jain
no flags Details
Screenshot of the change (398.64 KB, image/png)
2020-03-26 12:29 PDT, Aakash Jain
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-03-26 08:14:52 PDT
For configuration for which we have separate builder and testers (e.g.: ios-sim, ios-wk2), currently while builder build is going on, tester status-bubble keep pointing to builder's build. It start pointing to tester build, once the build starts on tester queue. However, while builder has finished builder, and patch is waiting on tester queue, status-bubble for tester queues should point to tester queue.
Comment 1 Aakash Jain 2020-03-26 08:20:34 PDT
Created attachment 394611 [details]
Patch
Comment 2 Aakash Jain 2020-03-26 08:20:56 PDT
e.g.: https://ews.webkit-uat.org/status-bubble/393344/
Comment 3 Jonathan Bedard 2020-03-26 09:21:06 PDT
Comment on attachment 394611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394611&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:127
> +                bubble['details_message'] = 'Waiting to run tests.'

I actually like the 'build is in-progress' line. Any reason to get rid of it?
Comment 4 Aakash Jain 2020-03-26 09:23:56 PDT
(In reply to Jonathan Bedard from comment #3)
> I actually like the 'build is in-progress' line. Any reason to get rid of it?
Probably because it is kind of misleading and might take the attention away from the main fact 'Waiting to run tests'. I don't have a strong opinion on it though.
Comment 5 Jonathan Bedard 2020-03-26 11:16:05 PDT
(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > I actually like the 'build is in-progress' line. Any reason to get rid of it?
> Probably because it is kind of misleading and might take the attention away
> from the main fact 'Waiting to run tests'. I don't have a strong opinion on
> it though.

Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?
Comment 6 Aakash Jain 2020-03-26 11:34:48 PDT
(In reply to Jonathan Bedard from comment #5)
> Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?
Yeah, it's when the tester is waiting in tester queue (because no bot is free on tester queue).

For e.g. hover-over message for ios-wk2 bubble for the patches corresponding to pending build-requests on https://ews-build.webkit.org/#/builders/iOS-13-Simulator-WK2-Tests-EWS
Comment 7 Jonathan Bedard 2020-03-26 11:46:49 PDT
(In reply to Aakash Jain from comment #6)
> (In reply to Jonathan Bedard from comment #5)
> > Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?
> Yeah, it's when the tester is waiting in tester queue (because no bot is
> free on tester queue).
> 
> For e.g. hover-over message for ios-wk2 bubble for the patches corresponding
> to pending build-requests on
> https://ews-build.webkit.org/#/builders/iOS-13-Simulator-WK2-Tests-EWS

So it sounds like it could be waiting for the build results or waiting for an available device.
Comment 8 Aakash Jain 2020-03-26 11:59:46 PDT
(In reply to Jonathan Bedard from comment #7)
> or waiting for an available device.
Yeah, this patch is only about the scenario in which it's waiting for available device. 

> So it sounds like it could be waiting for the build results 
If the build is on-going on builder, tester bubble simply mirrors information from the on-going builder build.
Comment 9 EWS 2020-03-26 12:05:57 PDT
Committed r259063: <https://trac.webkit.org/changeset/259063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394611 [details].
Comment 10 Radar WebKit Bug Importer 2020-03-26 12:06:50 PDT
<rdar://problem/60930006>
Comment 11 Aakash Jain 2020-03-26 12:20:38 PDT
Created attachment 394637 [details]
Screenshot of the change
Comment 12 Aakash Jain 2020-03-26 12:29:13 PDT
Landed a minor follow-up fix so that status-bubble hover-over message for tester, shows tester name while waiting on tester queue.

https://trac.webkit.org/changeset/259064/webkit
Comment 13 Aakash Jain 2020-03-26 12:29:49 PDT
Created attachment 394640 [details]
Screenshot of the change