Bug 209598 – [ews] status-bubble for tester queues should point to tester queue while waiting in queue

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

For configuration for which we have separate builder and testers (e.g.: ios-sim, ios-wk2), currently while builder build is going on, tester status-bubble keep pointing to builder's build. It start pointing to tester build, once the build starts on tester queue. However, while builder has finished builder, and patch is waiting on tester queue, status-bubble for tester queues should point to tester queue.

[Aakash Jain]

Created attachment 394611 [details]
Patch

[Aakash Jain]

e.g.: https://ews.webkit-uat.org/status-bubble/393344/

[Jonathan Bedard]

Comment on attachment 394611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394611&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:127
> +                bubble['details_message'] = 'Waiting to run tests.'

I actually like the 'build is in-progress' line. Any reason to get rid of it?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> I actually like the 'build is in-progress' line. Any reason to get rid of it?
Probably because it is kind of misleading and might take the attention away from the main fact 'Waiting to run tests'. I don't have a strong opinion on it though.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > I actually like the 'build is in-progress' line. Any reason to get rid of it?
> Probably because it is kind of misleading and might take the attention away
> from the main fact 'Waiting to run tests'. I don't have a strong opinion on
> it though.

Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #5)
> Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?
Yeah, it's when the tester is waiting in tester queue (because no bot is free on tester queue).

For e.g. hover-over message for ios-wk2 bubble for the patches corresponding to pending build-requests on https://ews-build.webkit.org/#/builders/iOS-13-Simulator-WK2-Tests-EWS

[Jonathan Bedard]

(In reply to Aakash Jain from comment #6)
> (In reply to Jonathan Bedard from comment #5)
> > Am I understanding correctly that this message is shown when the tester is waiting on the binaries from the builder?
> Yeah, it's when the tester is waiting in tester queue (because no bot is
> free on tester queue).
> 
> For e.g. hover-over message for ios-wk2 bubble for the patches corresponding
> to pending build-requests on
> https://ews-build.webkit.org/#/builders/iOS-13-Simulator-WK2-Tests-EWS

So it sounds like it could be waiting for the build results or waiting for an available device.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #7)
> or waiting for an available device.
Yeah, this patch is only about the scenario in which it's waiting for available device. 

> So it sounds like it could be waiting for the build results 
If the build is on-going on builder, tester bubble simply mirrors information from the on-going builder build.

[EWS]

Committed r259063: <https://trac.webkit.org/changeset/259063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394611 [details].

[Radar WebKit Bug Importer]

<rdar://problem/60930006>

[Aakash Jain]

Created attachment 394637 [details]
Screenshot of the change

[Aakash Jain]

Landed a minor follow-up fix so that status-bubble hover-over message for tester, shows tester name while waiting on tester queue.

https://trac.webkit.org/changeset/259064/webkit

[Aakash Jain]

Created attachment 394640 [details]
Screenshot of the change