Bug 209543 – [ews] status-bubble should link to buildbot queue while waiting in queue

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

While a patch is waiting in queue, its ews status bubble shows position in queue, but doesn't link to anything. I would be nice if the status-bubble could link to the corresponding buildbot queue. This will allow the users to easily navigate to corresponding buildbot queue and check recent builds and pending patches in queue.

[Aakash Jain]

Created attachment 394493 [details]
Patch

[Aakash Jain]

e.g.: https://ews.webkit-uat.org/status-bubble/394352/

[Radar WebKit Bug Importer]

<rdar://problem/60871777>

[Jonathan Bedard]

Comment on attachment 394493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99
> +            if self._get_parent_queue(queue):

Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something.

[Aakash Jain]

Comment on attachment 394493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99
>> +            if self._get_parent_queue(queue):
> 
> Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something.

Yeah, it's just a local dictionary lookup.

[EWS]

Committed r258997: <https://trac.webkit.org/changeset/258997>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394493 [details].