Bug 209511 - [WebGL2] Buffer updates
Summary: [WebGL2] Buffer updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 126404
  Show dependency tree / graph
 
Reported: 2020-03-24 15:26 PDT by Kenneth Russell
Modified: 2020-07-30 15:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.35 KB, patch)
2020-07-30 10:50 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
fix layout tests (22.59 KB, patch)
2020-07-30 11:48 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
rebase (34.92 KB, patch)
2020-07-30 12:01 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
fix missing trailing newline (34.92 KB, patch)
2020-07-30 13:13 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
actually fix missing trailing newline (34.92 KB, patch)
2020-07-30 14:03 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-03-24 15:26:08 PDT 
Buffer-related updates are needed for WebGL 2.0 in the following methods:
bufferData
bufferSubData
getBufferParameter
copyBufferSubData
getBufferSubData
Comment 1 James Darpinian 2020-07-24 16:31:03 PDT 
I will look at this one.
Comment 2 James Darpinian 2020-07-30 10:50:01 PDT 
Created attachment 405590 [details]
Patch
Comment 3 James Darpinian 2020-07-30 11:48:15 PDT 
Created attachment 405592 [details]
fix layout tests
Comment 4 James Darpinian 2020-07-30 12:01:34 PDT 
Created attachment 405593 [details]
rebase
Comment 5 James Darpinian 2020-07-30 13:13:48 PDT 
Created attachment 405602 [details]
fix missing trailing newline
Comment 6 Kenneth Russell 2020-07-30 13:22:45 PDT 
Comment on attachment 405602 [details]
fix missing trailing newline

Fantastic work James! Looks good to me.
Comment 7 James Darpinian 2020-07-30 14:03:30 PDT 
Created attachment 405612 [details]
actually fix missing trailing newline
Comment 8 EWS 2020-07-30 15:27:35 PDT 
Committed r265114: <https://trac.webkit.org/changeset/265114>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405612 [details].
Comment 9 Radar WebKit Bug Importer 2020-07-30 15:28:18 PDT 
<rdar://problem/66350700>