The goal is to make fast/attachment/attachment-default-icon.html more reliable. The test page has a default attachment while the expected page has a file attachment. The extension of this file is ".dat". The icon for this file attachment is not necessarily the same as the icon for the default attachment.
Created attachment 393813 [details] Patch
<rdar://problem/59606671>
Comment on attachment 393813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review This patch looks good. > LayoutTests/ChangeLog:9 > + returns for âpublic.dataâ icon. Ok as-is. No change needed. There are some fancy quotes here.
Comment on attachment 393813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review > LayoutTests/fast/attachment/attachment-default-icon-expected.html:4 > +<attachment id="attachment" title=" " type="public.data"></attachment> After looking at other attachment tests, I think I understand what this test was going for....it's trying to test the code path for the file attribute matches the code path for the missing type attribute (which yields the default icon). The implicit assumption this test makes is that a .dat file yields the default icon. For this test (and only this test as I haven't studied the others enough,yet) this patch seems reasonable because: 1. There are other tests that actually check that the file attribute affects the icon 2. Because of (1) this test just needs to focus on testing that the icon is for the missing type attribute is equivalent to the icon for a .dat file.
Comment on attachment 393813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review > LayoutTests/ChangeLog:5 > + Ok as-is. No change needed. The optimal ChangeLog includes the radar URL here because: 1. Convenient for Apple engineers
Created attachment 393854 [details] Patch
The commit-queue encountered the following flaky tests while processing attachment 393854 [details]: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849 The commit-queue is continuing to process your patch.
Comment on attachment 393854 [details] Patch Clearing flags on attachment: 393854 Committed r258640: <https://trac.webkit.org/changeset/258640>
All reviewed patches have been landed. Closing bug.