Bug 176769 – Dragging & dropping a file creates an attachment element even when it's disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

When dragging & dropping a file, we end up creating an attachment element even when the feature is disabled by settings.
We also expose HTMLAttachmentElement in the global object even when this feature is enabled at runtime.

Fix all these issues by replacing the settings by a runtime flag.

[Ryosuke Niwa]

Created attachment 320527 [details]
Patch

[Ryosuke Niwa]

Created attachment 320529 [details]
Fixed tests

[Build Bot]

Comment on attachment 320529 [details]
Fixed tests

Attachment 320529 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4522204

New failing tests:
fast/attachment/attachment-select-on-click.html
accessibility/ios-simulator/attributed-string-for-range.html

[Build Bot]

Created attachment 320533 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Tim Horton]

Comment on attachment 320529 [details]
Fixed tests

View in context: https://bugs.webkit.org/attachment.cgi?id=320529&action=review

Woo! Thank you for fixing this :) It has haunted the back of my mind for years.

> Source/WebCore/ChangeLog:12
> +        To fix the bug that HTMLAttachElement is always exposed on the global object even when it's disabled

HTMLAttachmentElement.

[Ryosuke Niwa]

Created attachment 320566 [details]
Patch for landing

[Ryosuke Niwa]

Comment on attachment 320566 [details]
Patch for landing

Wait for EWS.

[WebKit Commit Bot]

Comment on attachment 320566 [details]
Patch for landing

Clearing flags on attachment: 320566

Committed r221944: <http://trac.webkit.org/changeset/221944>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693484>