Bug 208947 - REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&) should set m_isRectBased to true
Summary: REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, con...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on: 208254
  Show dependency treegraph
Reported: 2020-03-11 14:48 PDT by Daniel Bates
Modified: 2020-03-11 17:42 PDT (History)
8 users (show)

See Also:

Patch (1.57 KB, patch)
2020-03-11 14:52 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-11 14:48:00 PDT
In bug #208254 I inadvertently removed setting m_isRectBased to true in the constructor HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&). So, it is now set to false. This does not match the original intention of the code and should be reverted.
Comment 1 Daniel Bates 2020-03-11 14:52:37 PDT
Created attachment 393290 [details]
Comment 2 Daniel Bates 2020-03-11 14:57:38 PDT
Comment on attachment 393290 [details]

Clearing flags on attachment: 393290

Committed r258287: <https://trac.webkit.org/changeset/258287>
Comment 3 Daniel Bates 2020-03-11 14:57:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-03-11 14:58:16 PDT
Comment 5 Simon Fraser (smfr) 2020-03-11 17:35:33 PDT
Did the error cause layout test failures? Should this patch have landed with a test?
Comment 6 Daniel Bates 2020-03-11 17:42:26 PDT
(In reply to Simon Fraser (smfr) from comment #5)
> Did the error cause layout test failures? Should this patch have landed with
> a test?

I don't know. I found this issue by code inspection. When I have a moment I will look to write one.