Bug 208254 - Clean up HitTestLocation.h
Summary: Clean up HitTestLocation.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 208947
  Show dependency tree / graph
 
Reported: 2020-02-26 11:55 PST by Daniel Bates
Modified: 2020-03-11 15:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2020-02-26 12:01 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-02-26 11:55:25 PST 
Use C++11 and later features to reduce code duplication and simplify the code in HitTestLocation.h. This will make it easier for me to add a new rect-based location constructor in the future.
Comment 1 Radar WebKit Bug Importer 2020-02-26 11:55:37 PST 
<rdar://problem/59815136>
Comment 2 Daniel Bates 2020-02-26 12:01:35 PST 
Created attachment 391765 [details]
Patch
Comment 3 Daniel Bates 2020-02-26 12:05:10 PST 
Comment on attachment 391765 [details]
Patch

Clearing flags on attachment: 391765

Committed r257502: <https://trac.webkit.org/changeset/257502>
Comment 4 Daniel Bates 2020-02-26 12:05:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Daniel Bates 2020-03-11 14:44:57 PDT 
Comment on attachment 391765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391765&action=review

> Source/WebCore/rendering/HitTestLocation.cpp:-56
> -    , m_isRectBased(true)

This is wrong. This needs to be set to true.
Comment 6 Daniel Bates 2020-03-11 15:48:49 PDT 
(In reply to Daniel Bates from comment #5)
> Comment on attachment 391765 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391765&action=review
> 
> > Source/WebCore/rendering/HitTestLocation.cpp:-56
> > -    , m_isRectBased(true)
> 
> This is wrong. This needs to be set to true.

Fixed in bug #208947.