Bug 208936 - [GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage()
Summary: [GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 12:37 PDT by Said Abou-Hallawa
Modified: 2020-03-11 21:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2020-03-11 12:44 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-03-11 12:37:39 PDT 
The current call in encodeNativeImage() passes an empty FloatSize for the argument 'imageSize'. This causes the NativeImage not be be drawn to the ShareableBitmap. So encoding the NativeImage was always sending zero image from the WebProcess to the GPUProcess.
Comment 1 Said Abou-Hallawa 2020-03-11 12:44:02 PDT 
Created attachment 393277 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-03-11 12:44:35 PDT 
This patch lowers the failures of the command 

run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas  --internal-feature RenderCanvasInGPUProcessEnabled

from 69 to 45 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876 and https://bugs.webkit.org/show_bug.cgi?id=208931).
Comment 3 WebKit Commit Bot 2020-03-11 21:25:04 PDT 
Comment on attachment 393277 [details]
Patch

Clearing flags on attachment: 393277

Committed r258312: <https://trac.webkit.org/changeset/258312>
Comment 4 WebKit Commit Bot 2020-03-11 21:25:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-11 21:26:17 PDT 
<rdar://problem/60355796>