Bug 208931 - [GPU Process] RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext()
Summary: [GPU Process] RemoteImageBuffer::getImageData() has to clear its DisplayList ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 11:22 PDT by Said Abou-Hallawa
Modified: 2020-03-11 21:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.74 KB, patch)
2020-03-11 11:27 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2020-03-11 11:22:45 PDT 
Otherwise the same drawing commands will be replayed back anytime the backend is checked for uncommitted drawing.
Comment 1 Said Abou-Hallawa 2020-03-11 11:27:52 PDT 
Created attachment 393269 [details]
Patch
Comment 2 Said Abou-Hallawa 2020-03-11 12:16:42 PDT 
This patch lowers the failures of the command 

run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas  --internal-feature RenderCanvasInGPUProcessEnabled

from 100 to 68 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876).
Comment 3 WebKit Commit Bot 2020-03-11 21:20:03 PDT 
Comment on attachment 393269 [details]
Patch

Clearing flags on attachment: 393269

Committed r258311: <https://trac.webkit.org/changeset/258311>
Comment 4 WebKit Commit Bot 2020-03-11 21:20:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-11 21:21:18 PDT 
<rdar://problem/60355642>