Bug 20884 - Fix LayoutTests that call notifyDone() twice
Summary: Fix LayoutTests that call notifyDone() twice
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2008-09-16 10:29 PDT by Simon Fraser (smfr)
Modified: 2008-12-17 20:17 PST (History)
2 users (show)

See Also:

Fix test to not call notifyDone() twice (1.21 KB, patch)
2008-09-16 13:03 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-09-16 10:29:14 PDT
Following on from bug 20875, some tests call notifyDone() twice. This used to result in memory corruption; now it results in test failure (possibly on some later test).
Comment 1 Simon Fraser (smfr) 2008-09-16 10:38:13 PDT
I get occasional failures in fast/dom/gc-9.html, which suggest that fast/dom/gc-7.html or fast/dom/gc-8.html are doing something bad.
Comment 2 Simon Fraser (smfr) 2008-09-16 12:43:47 PDT
A test prior to svg/custom/gradient-cycle-detection.html also seems to have issues.

Bug 20881 covers animations/change-one-anim.html 
Comment 3 Simon Fraser (smfr) 2008-09-16 12:55:22 PDT
Looks like gradient-attr-update.svg can call notifyDone() twice because myfunc() is called both by the onload, and by the onclick. I'm not sure how to fix that test.
Comment 4 Simon Fraser (smfr) 2008-09-16 13:03:02 PDT
Created attachment 23483 [details]
Fix test to not call notifyDone() twice
Comment 5 Simon Fraser (smfr) 2008-09-16 13:16:18 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/animations/change-one-anim.html
	M	LayoutTests/svg/custom/gradient-attr-update.svg
Committed r36520

Keeping bug open for fast/dom/gc-8.html
Comment 6 Darin Adler 2008-09-17 14:47:23 PDT
Comment on attachment 23483 [details]
Fix test to not call notifyDone() twice

rs=me -- needs ChangeLog -- fix seems a little indirect to me, but should be fine
Comment 7 Adam Barth 2008-10-14 01:37:58 PDT
Will land.  I'll add a ChangeLog because I'm that nice.
Comment 8 Adam Barth 2008-10-14 02:05:21 PDT
Comment on attachment 23483 [details]
Fix test to not call notifyDone() twice

Clearing review flag.  This has already been landed.  Keeping open per comment above.
Comment 9 Simon Fraser (smfr) 2008-12-17 20:17:28 PST
I don't think anything remains now.