RESOLVED FIXED 20884
Fix LayoutTests that call notifyDone() twice 
https://bugs.webkit.org/show_bug.cgi?id=20884
Summary Fix LayoutTests that call notifyDone() twice
Simon Fraser (smfr)
Reported 2008-09-16 10:29:14 PDT
Following on from bug 20875, some tests call notifyDone() twice. This used to result in memory corruption; now it results in test failure (possibly on some later test).
Attachments
Fix test to not call notifyDone() twice (1.21 KB, patch)
2008-09-16 13:03 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-09-16 10:38:13 PDT
I get occasional failures in fast/dom/gc-9.html, which suggest that fast/dom/gc-7.html or fast/dom/gc-8.html are doing something bad.
Simon Fraser (smfr)
Comment 2 2008-09-16 12:43:47 PDT
A test prior to svg/custom/gradient-cycle-detection.html also seems to have issues. Bug 20881 covers animations/change-one-anim.html
Simon Fraser (smfr)
Comment 3 2008-09-16 12:55:22 PDT
Looks like gradient-attr-update.svg can call notifyDone() twice because myfunc() is called both by the onload, and by the onclick. I'm not sure how to fix that test.
Simon Fraser (smfr)
Comment 4 2008-09-16 13:03:02 PDT
Created attachment 23483 [details] Fix test to not call notifyDone() twice
Simon Fraser (smfr)
Comment 5 2008-09-16 13:16:18 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/change-one-anim.html M LayoutTests/svg/custom/gradient-attr-update.svg Committed r36520 Keeping bug open for fast/dom/gc-8.html
Darin Adler
Comment 6 2008-09-17 14:47:23 PDT
Comment on attachment 23483 [details] Fix test to not call notifyDone() twice rs=me -- needs ChangeLog -- fix seems a little indirect to me, but should be fine
Adam Barth
Comment 7 2008-10-14 01:37:58 PDT
Will land. I'll add a ChangeLog because I'm that nice.
Adam Barth
Comment 8 2008-10-14 02:05:21 PDT
Comment on attachment 23483 [details] Fix test to not call notifyDone() twice Clearing review flag. This has already been landed. Keeping open per comment above.
Simon Fraser (smfr)
Comment 9 2008-12-17 20:17:28 PST
I don't think anything remains now.
Note You need to log in before you can comment on or make changes to this bug.