Bug 20881 - change-one-anim.html test causes crash in DRT
Summary: change-one-anim.html test causes crash in DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-16 09:04 PDT by Chris Marrin
Modified: 2008-09-16 13:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch to fix bug (1.03 KB, patch)
2008-09-16 09:07 PDT, Chris Marrin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2008-09-16 09:04:05 PDT 
This test calls layoutTestController.notifyDone() twice. Simon and I tracked this down as the source of the crashes we have been seeing in DRT.  It looks like the crash is happening because notifyDone is being called after the layoutTestController has been destroyed, causing memory corruption. Soon thereafter some random memory smasher happens.

Simon is looking at fixing the norifyDone problem. I have also fixed the test to avoid the second call to notifyDone, and the crash goes away. Patch attached.
Comment 1 Chris Marrin 2008-09-16 09:07:50 PDT 
Created attachment 23474 [details]
Patch to fix bug
Comment 2 Simon Fraser (smfr) 2008-09-16 09:09:55 PDT 
Change looks good to me.
Comment 3 Darin Adler 2008-09-16 09:47:25 PDT 
Comment on attachment 23474 [details]
Patch to fix bug

r=me

It would be slightly better if the change log explained what was wrong and what the fix accomplishes.
Comment 4 Simon Fraser (smfr) 2008-09-16 13:16:29 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/animations/change-one-anim.html
	M	LayoutTests/svg/custom/gradient-attr-update.svg
Committed r36520