RESOLVED FIXED 20881
change-one-anim.html test causes crash in DRT 
https://bugs.webkit.org/show_bug.cgi?id=20881
Summary change-one-anim.html test causes crash in DRT
Chris Marrin
Reported 2008-09-16 09:04:05 PDT
This test calls layoutTestController.notifyDone() twice. Simon and I tracked this down as the source of the crashes we have been seeing in DRT. It looks like the crash is happening because notifyDone is being called after the layoutTestController has been destroyed, causing memory corruption. Soon thereafter some random memory smasher happens. Simon is looking at fixing the norifyDone problem. I have also fixed the test to avoid the second call to notifyDone, and the crash goes away. Patch attached.
Attachments
Patch to fix bug (1.03 KB, patch)
2008-09-16 09:07 PDT, Chris Marrin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2008-09-16 09:07:50 PDT
Created attachment 23474 [details] Patch to fix bug
Simon Fraser (smfr)
Comment 2 2008-09-16 09:09:55 PDT
Change looks good to me.
Darin Adler
Comment 3 2008-09-16 09:47:25 PDT
Comment on attachment 23474 [details] Patch to fix bug r=me It would be slightly better if the change log explained what was wrong and what the fix accomplishes.
Simon Fraser (smfr)
Comment 4 2008-09-16 13:16:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/change-one-anim.html M LayoutTests/svg/custom/gradient-attr-update.svg Committed r36520
Note You need to log in before you can comment on or make changes to this bug.