Bug 208771 – [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Fujii Hironori]

[CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj

CMake Visual Studio generator put a custom command of
GenerateSettings.rb into both WebCoreBindings.vcxproj and
WebCoreTestSupportBindings.vcxproj because both projects are
using the generated files as source files. This causes
unnecessary recompilation.

The fundamental issue of this bug was fixed in CMake side.
https://gitlab.kitware.com/cmake/cmake/issues/16767

However, WebCoreTestSupportBindings needs to have a direct or
indirect dependency to WebCoreBindings for CMake Visual Studio
generator to eliminate duplicated custom commands. Otherwise,
GenerateSettings.rb will be triggered in both projects.

See also:

Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects
Bug 181117 – [CMake][Win] Visual Studio invokes make_names.pl twice

[Fujii Hironori]

Created attachment 392897 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 392897 [details]
Patch

Clearing flags on attachment: 392897

Committed r258083: <https://trac.webkit.org/changeset/258083>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.